[MacViews] Wire up ExtensionUninstallDialog |
||
Issue descriptionThis is only called via ExtensionUninstallDialog::Create().
,
Jun 8 2017
This is just an NSAlert on Mac. I don't feel strongly that all NSAlerts must be purged before rolling out the rest of Harmony, but most of these are simple to wire up anyway.
,
Jul 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb8556546fdcaa1419452903e8c061454d4af78 commit cfb8556546fdcaa1419452903e8c061454d4af78 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Jul 25 16:41:37 2017 macviews: wire extension uninstall dialog This dialog appears when uninstalling an extension. Bug: 728168 Change-Id: If3955b1ef3e0158efb6e3c665de63857765f9a5f Reviewed-on: https://chromium-review.googlesource.com/575837 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#489336} [modify] https://crrev.com/cfb8556546fdcaa1419452903e8c061454d4af78/chrome/browser/extensions/extension_uninstall_dialog.h [modify] https://crrev.com/cfb8556546fdcaa1419452903e8c061454d4af78/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/cfb8556546fdcaa1419452903e8c061454d4af78/chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm [modify] https://crrev.com/cfb8556546fdcaa1419452903e8c061454d4af78/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
,
Jul 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by tapted@chromium.org
, Jun 8 2017Labels: Proj-MacViews