New issue
Advanced search Search tips

Issue 728165 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 603386



Sign in to add a comment

[MacViews] Wire up SaveCardBubbleViews

Project Member Reported by ellyjo...@chromium.org, May 31 2017

Issue description

This probably needs to happen in BrowserWindowCocoa::ShowSaveCreditCardBubble().
 
Blocking: 730958
Labels: Proj-MacViews
I think we can punt these to a later phase. See  Issue 730958 .
Blocking: -730958 603386
Labels: Phase3
Oops - this one shouldn't be punted. Mock in  Issue 654115 .

And actually  http://crbug.com/654115#c8  -> r466285 suggests this is already linked in on Mac, but maybe not completely wired up. Might be an easy one to finish off.
Harmony dialog.
Screen Shot 2017-08-11 at 1.05.56 PM.png
29.0 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cca4035929471c822d87960d47e6ac49040ce0e8

commit cca4035929471c822d87960d47e6ac49040ce0e8
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Sep 27 16:24:13 2017

macviews: wire CC save dialog

This change:
1) Reroutes invocations of this dialog from BrowserWindow to TabDialogs
2) Adds a TestTabDialogs subclass of TabDialogs for unit tests to override
   individual methods
3) Changes SaveCardBubbleView to accept an anchor point

Bug:  728165 
Change-Id: I3776bd0c9e17f3722685df1cbb25ff5d82e30537
Reviewed-on: https://chromium-review.googlesource.com/598546
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504698}
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.h
[add] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/autofill/save_card_bubble_view_views.mm
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/autofill/save_card_bubble_views.h
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/cca4035929471c822d87960d47e6ac49040ce0e8/chrome/browser/ui/views/toolbar/toolbar_view.h

Status: Fixed (was: Available)

Sign in to add a comment