New issue
Advanced search Search tips

Issue 728163 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 730958



Sign in to add a comment

[MacViews] Wire up ScreenCaptureNotificationUI

Project Member Reported by ellyjo...@chromium.org, May 31 2017

Issue description

This is implemented in ScreenCaptureNotificationUI::Create().
 
Blocking: 730958
Labels: Proj-MacViews
I think we can punt these to a later phase. See  Issue 730958 .
Labels: M-X
Owner: robliao@chromium.org
Status: Assigned (was: Available)
Summary: [MacViews] Wire up ScreenCaptureNotificationUI (was: [MacViews] Wire up ScreenCaptureNotification)
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ccc77f21d6499d99adae6708fde5ce5223c0f3e

commit 2ccc77f21d6499d99adae6708fde5ce5223c0f3e
Author: Robert Liao <robliao@chromium.org>
Date: Thu Feb 22 19:34:22 2018

Add ScreenCaptureNotificationUIBrowserTest

This provides an easy way to bring up the ScreenCaptureNotificationUI
via
browser_tests --gtest_filter=ScreenCaptureNotificationUiBrowserTest.InvokeUi --test-launcher-interactive

BUG= 728163 

Change-Id: Ibb5159cec393c7613f571f529536727c95266cf6
Reviewed-on: https://chromium-review.googlesource.com/930126
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538523}
[add] https://crrev.com/2ccc77f21d6499d99adae6708fde5ce5223c0f3e/chrome/browser/ui/screen_capture_notification_ui_browsertest.cc
[modify] https://crrev.com/2ccc77f21d6499d99adae6708fde5ce5223c0f3e/chrome/test/BUILD.gn

Differences between the two attached.
Cocoa.png
12.8 KB View Download
Views.png
12.7 KB View Download
we should probably change this to use MdTextButton::CreateSecondaryUiBlueButton...

that will make it less different to Cocoa on Mac, and more consistent with other dialogs everywhere else.
oh whoops. it is using that :o. I had my screenshots backwards. looks neat :)
Labels: -M-X Target-68
MacViews triage: robliao: this is done now, right? If so please mark Fixed :) if not let's target the rest of the work for this at M68.
Status: Fixed (was: Started)
Yep. Just verified this is good to go in Canary today.

Sign in to add a comment