[MacViews] Wire up ScreenCaptureNotificationUI |
|||||||
Issue descriptionThis is implemented in ScreenCaptureNotificationUI::Create().
,
Oct 16 2017
,
Feb 16 2018
,
Feb 20 2018
,
Feb 22 2018
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ccc77f21d6499d99adae6708fde5ce5223c0f3e commit 2ccc77f21d6499d99adae6708fde5ce5223c0f3e Author: Robert Liao <robliao@chromium.org> Date: Thu Feb 22 19:34:22 2018 Add ScreenCaptureNotificationUIBrowserTest This provides an easy way to bring up the ScreenCaptureNotificationUI via browser_tests --gtest_filter=ScreenCaptureNotificationUiBrowserTest.InvokeUi --test-launcher-interactive BUG= 728163 Change-Id: Ibb5159cec393c7613f571f529536727c95266cf6 Reviewed-on: https://chromium-review.googlesource.com/930126 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#538523} [add] https://crrev.com/2ccc77f21d6499d99adae6708fde5ce5223c0f3e/chrome/browser/ui/screen_capture_notification_ui_browsertest.cc [modify] https://crrev.com/2ccc77f21d6499d99adae6708fde5ce5223c0f3e/chrome/test/BUILD.gn
,
Mar 9 2018
Differences between the two attached.
,
Mar 9 2018
we should probably change this to use MdTextButton::CreateSecondaryUiBlueButton... that will make it less different to Cocoa on Mac, and more consistent with other dialogs everywhere else.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/618a22f7ba4c21447ef089e38cd7173a527ade2c commit 618a22f7ba4c21447ef089e38cd7173a527ade2c Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 09 02:31:25 2018 Wire Up ScreenCaptureNotificationUIViews to the Cocoa Browser BUG= 728163 Change-Id: Ib519ec4a7ee122301c1ff17dc2f76cf66e48e465 Reviewed-on: https://chromium-review.googlesource.com/932014 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#541999} [modify] https://crrev.com/618a22f7ba4c21447ef089e38cd7173a527ade2c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/618a22f7ba4c21447ef089e38cd7173a527ade2c/chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm [modify] https://crrev.com/618a22f7ba4c21447ef089e38cd7173a527ade2c/chrome/browser/ui/screen_capture_notification_ui.h [modify] https://crrev.com/618a22f7ba4c21447ef089e38cd7173a527ade2c/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
,
Mar 9 2018
oh whoops. it is using that :o. I had my screenshots backwards. looks neat :)
,
Mar 23 2018
MacViews triage: robliao: this is done now, right? If so please mark Fixed :) if not let's target the rest of the work for this at M68.
,
Mar 23 2018
Yep. Just verified this is good to go in Canary today. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tapted@chromium.org
, Jun 8 2017Labels: Proj-MacViews