👍

BookmarkAppConfirmationView is behind its own flag, so I'm just deleting the NSAlert we currently use. It's buggy anyway (e.g. the NSTextField we jam in there doesn't scroll).

https://codereview.chromium.org/2916753004

Deleted: Screen Shot 2017-06-02 at 1.03.51 pm.png 104 KB

	Screen Shot 2017-06-02 at 1.03.51 pm.png 104 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712c1b8ba3219ffe2408837d7b2f2f1253a55f26

commit 712c1b8ba3219ffe2408837d7b2f2f1253a55f26
Author: tapted <tapted@chromium.org>
Date: Thu Jun 08 03:10:05 2017

Use BookmarkAppConfirmationView on Mac. Delete the NSAlert Mac uses currently.

This dialog can only be shown on Mac by turning on a flag. The NSAlert
is ugly and buggy, so just delete it.

Remove a bunch of unnecessary plumbing. Renames ShowBookmarkAppBubble to
ShowBookmarkAppDialog (since it's not a bubble).

Adds a test harness for BookmarkAppHelper integration tests and add an
end-to-end test for showing the dialog.

Adds BookmarkAppHelperTest.InvokeDialog_create to browser_tests. The
dialog can be shown interactively with something like

browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive \
--dialog=BookmarkAppHelperTest.InvokeDialog_create

BUG= 728153 

Review-Url: https://codereview.chromium.org/2916753004
Cr-Commit-Position: refs/heads/master@{#477871}

[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/app/generated_resources.grd
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/extensions/bookmark_app_helper.h
[add] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/extensions/bookmark_app_helper_browsertest.cc
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/test/BUILD.gn
[modify] https://crrev.com/712c1b8ba3219ffe2408837d7b2f2f1253a55f26/chrome/test/base/test_browser_window.h

CreateChromeApplicationShortcutView -> https://codereview.chromium.org/2929733003

Deleted: create_app_shortcuts_mock.png 207 KB

	create_app_shortcuts_mock.png 207 KB View Download

Deleted: old.png 28.7 KB

	old.png 28.7 KB View Download

Deleted: new.png 55.0 KB

	new.png 55.0 KB View Download

Huh. Actually the image in #c4 isn't a mock - just a screengrab from Windows from Apr 17. I don't think we have mocks for this. Only for BookmarkAppConfirmationView. Which is in  Issue 652510  (and which the screengrab in #c2 corresponds to).

These should probably block MacViews/Harmony being on by default on Mac. Which I've been calling "Phase 3" --  Issue 603386 

Started a thread to discuss simply removing this dialog on Mac. It doesn't give any choice to a user - it's Applications folder or nothing.

CL to do this: https://codereview.chromium.org/2929773002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87

commit 2b82aa8c13c7fb73b0e1931adc1388a0ce986a87
Author: tapted <tapted@chromium.org>
Date: Fri Jun 09 05:51:09 2017

Mac: Remove create_application_shortcut_cocoa.mm

On Mac, the dialog doesn't give any choice to the user, so assume they
will make the only choice they can make, which is to make a shortcut.

Remove trailing ellipses from the UI surface that invokes this on Mac.

BUG= 728153 

Review-Url: https://codereview.chromium.org/2929773002
Cr-Commit-Position: refs/heads/master@{#478212}

[modify] https://crrev.com/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87/chrome/app/generated_resources.grd
[modify] https://crrev.com/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/feef72d0d19c8336b0199b6b7c8ad10b0251f675/chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm
[modify] https://crrev.com/2b82aa8c13c7fb73b0e1931adc1388a0ce986a87/chrome/browser/web_applications/web_app_mac.mm