Prevent Android from showing 2D screenshot of Chrome when entering VR. |
|||||||||
Issue descriptionWhen resuming an Activity, Android shows a 2D screenshot of the last state that Activity was in to try to improve perceived responsiveness. This works against us in VR, where we really don't wan't to draw anything until we're ready to show 3D content. We should do something like displaying only black until we're ready to show 3D content.
,
Jun 1 2017
Going to let this bake on Canary for a day or two then request a merge.
,
Jun 1 2017
Issue 726590 has been merged into this issue.
,
Jun 2 2017
,
Jun 2 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d2c3e91d531a0565726650dbccceacc39dfb8a7 commit 1d2c3e91d531a0565726650dbccceacc39dfb8a7 Author: Michael Thiessen <mthiesse@google.com> Date: Mon Jun 05 14:22:46 2017 VR: Hide 2D screenshot when resuming activities in VR and hide 2D UI while loading VR UI. This CL adds an animation that keeps the resuming Activity hidden for 500ms while starting up to allow time for us to draw the black overlay, also added in this CL, and prevent 2D UI from being shown while entering VR. This also performs some cleanup around VR entry (now that it's even more async than before) to ensure that we don't continue trying to enter VR after we try to exit VR (like when the activity is paused, etc.). Bug: 728148 Change-Id: I344ad661b632bde74764b134e9d9f70f6258d68d Reviewed-on: https://chromium-review.googlesource.com/519483 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476301} Review-Url: https://codereview.chromium.org/2917393002 . Cr-Commit-Position: refs/branch-heads/3112@{#148} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [add] https://crrev.com/1d2c3e91d531a0565726650dbccceacc39dfb8a7/chrome/android/java/res/anim/stay_hidden.xml [modify] https://crrev.com/1d2c3e91d531a0565726650dbccceacc39dfb8a7/chrome/android/java/res/values-v17/styles.xml [modify] https://crrev.com/1d2c3e91d531a0565726650dbccceacc39dfb8a7/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jun 5 2017
,
Jun 9 2017
,
Jun 9 2017
,
Jul 26 2017
Hi Michael, I verified this in 60.0.3112.78 by checking that after the DON flow, immediately after syncing the controller, and before the 3D presentation starts, no 2D screenshot is displayed. Please let me know if that is not the correct verification. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2017