VR: Adjust UI colors and elements positioning to improve UX |
|||||||
Issue descriptionProblems that we currently have: - The URL bar doesn't stand enough from the background on normal mode. - The loading indicator is too close to the URL bar - The URL bar needs to face the user because its low position on the scene.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af9e620d3dff0161d3dc9f8ef3607dfff69ca315 commit af9e620d3dff0161d3dc9f8ef3607dfff69ca315 Author: acondor <acondor@google.com> Date: Fri Jun 02 21:31:40 2017 VR: Improving UI colors and elements positioning - Updated colors for normal, fullscreen and incognito mode. - Tilting the URL bar to face the user. - Updated content size to 800*533px. This required the increase of DPR from 1.2 to 1.4 to keep the sharpness of text. BUG= 728147 Review-Url: https://codereview.chromium.org/2915483002 Cr-Commit-Position: refs/heads/master@{#476798} [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/browser/android/vr_shell/color_scheme.cc [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/browser/android/vr_shell/color_scheme.h [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc [modify] https://crrev.com/af9e620d3dff0161d3dc9f8ef3607dfff69ca315/chrome/browser/android/vr_shell/ui_scene_manager.cc
,
Jun 5 2017
,
Jun 5 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
Assigning to mthiesse for the merge. I think Aldo assigned it to me thinking I could do the merge, but I would have to get a committer to lgtm it anyway.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bf3fd87d28eaa2554bce23eb14fd34797527a25 commit 6bf3fd87d28eaa2554bce23eb14fd34797527a25 Author: Christopher Grant <cjgrant@google.com> Date: Tue Jun 06 14:30:30 2017 VR: Improving UI colors and elements positioning - Updated colors for normal, fullscreen and incognito mode. - Tilting the URL bar to face the user. - Updated content size to 800*533px. This required the increase of DPR from 1.2 to 1.4 to keep the sharpness of text. BUG= 728147 Review-Url: https://codereview.chromium.org/2915483002 Cr-Original-Commit-Position: refs/heads/master@{#476798} Review-Url: https://codereview.chromium.org/2928593002 . Cr-Commit-Position: refs/branch-heads/3112@{#182} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/browser/android/vr_shell/color_scheme.cc [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/browser/android/vr_shell/color_scheme.h [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc [modify] https://crrev.com/6bf3fd87d28eaa2554bce23eb14fd34797527a25/chrome/browser/android/vr_shell/ui_scene_manager.cc
,
Jun 6 2017
,
Jun 7 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by acondor@google.com
, Jun 2 2017Owner: amp@chromium.org