New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728146 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Implement a more natural grid for the environment

Project Member Reported by acondor@google.com, May 31 2017

Issue description

The environment of the VR browser is composed by a circular faded grid. Currently we implement it with glDrawLines. The problem with that approach is that we can not control width, sharpness or the width reduction for further lines.
Additionally, this approach requires an extra quad drawn slightly below the grid for drawing the background.
 

Comment 1 by acondor@google.com, May 31 2017

Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e

commit 5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e
Author: acondor <acondor@google.com>
Date: Wed May 31 16:23:04 2017

VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG= 728146 
# Presubmit doesn't like float casts in the shader code, which it thinks is c++ when it isn't.
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2907203002
Cr-Commit-Position: refs/heads/master@{#475935}

[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/5d5052f3e33d06bf1f6710a8e1a94fd972e9c83e/chrome/browser/android/vr_shell/vr_shell_renderer.h

Comment 3 by acondor@google.com, Jun 1 2017

Labels: Merge-Request-60
Status: Started (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf486993e67211dd0a470bd86f4c3eec1234df4

commit 2cf486993e67211dd0a470bd86f4c3eec1234df4
Author: acondor <acondor@google.com>
Date: Thu Jun 01 18:07:10 2017

VR: Soften the floor grid

- The grid is now drawn in the fragment shader instead of calling DrawLines.
- A single quad is used for the floor, mixing the background and the grid itself in a single shader.
- The geometry simplifies from a set of lines to a single quad.
- The precision for gradient shaders was set to low to reduce stress in the GPU.

BUG= 728146 
 Presubmit doesn't like float casts in the shader code, which it thinks is c++ when it isn't.
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2907203002
Cr-Original-Commit-Position: refs/heads/master@{#475935}
Review-Url: https://codereview.chromium.org/2915143002
Cr-Commit-Position: refs/branch-heads/3112@{#98}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/ui_elements/ui_element.h
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/ui_scene_manager.cc
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/ui_scene_manager.h
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/vr_shell_renderer.cc
[modify] https://crrev.com/2cf486993e67211dd0a470bd86f4c3eec1234df4/chrome/browser/android/vr_shell/vr_shell_renderer.h

Comment 6 by acondor@google.com, Jun 1 2017

Status: Fixed (was: Started)
Labels: Proj-VR-Shell

Sign in to add a comment