New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer working on chrome
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 713225



Sign in to add a comment

Fullscreen orientation lock glitch with rotate-to-fullscreen when rotating opposite to lock

Project Member Reported by joh...@chromium.org, May 31 2017

Issue description

Chrome Version: ToT
OS: Android phone

What steps will reproduce the problem?
(1) Use an Android phone (tablets are excluded)
(2) Use Chrome >= 60.0.3111.0
(3) Enable chrome://flags/#video-rotate-to-fullscreen (and leave chrome://flags/#video-fullscreen-orientation-lock enabled)
(4) Visit a page with native video controls, e.g. https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
(5) Make sure Android Quick Settings > Auto-rotate is enabled
(6) Hold the phone in portrait-primary orientation
(7) Press fullscreen on the video. The screen should become locked to landscape and hence show as landscape-primary
(8) Rotate the phone from portrait-primary to landscape-secondary (i.e. the opposite orientation to the one it got locked to)

What is the expected result?

The screen orientation should change directly from fullscreen landscape-primary to fullscreen landscape-secondary (without going via any portrait orientations or leaving fullscreen).

What happens instead?

It depends on the exact timing between pressing fullscreen and rotating the device, and perhaps also on the speed at which the device is rotated. But two failure modes sometimes occur:
(a) screen orientation changes from fullscreen landscape-primary to inline portrait-primary, before then continuing to fullscreen landscape-secondary
(b) screen orientation changes from fullscreen landscape-primary to inline landscape-secondary
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e

commit eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e
Author: johnme <johnme@chromium.org>
Date: Thu Jun 15 15:43:59 2017

[Media Controls] Prevent fullscreen orientation lock rotate glitch

When both chrome://flags/#video-rotate-to-fullscreen and
chrome://flags/#video-fullscreen-orientation-lock are enabled, pressing
the fullscreen button then rotating the device to the opposite
orientation than the one that was locked to could result in jank or
accidentally exiting fullscreen. This patch works around those problems.

BUG= 728145 

Review-Url: https://codereview.chromium.org/2919513002
Cr-Commit-Position: refs/heads/master@{#479715}

[modify] https://crrev.com/eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[modify] https://crrev.com/eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.h
[modify] https://crrev.com/eeb22bd5bbaa417f1265e1fa596321d74d5e7f1e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp

Comment 2 by joh...@chromium.org, Jun 16 2017

Labels: M-61
Status: Fixed (was: Started)

Sign in to add a comment