I think we can punt these to a later phase. See  Issue 730958 .

ProfileChooserView is the Windows/Linux version.
ProfileChooserController is the macOS version.

Those classes are used to display the profile chooser menu when the profile button is clicked.

I have no clue what UserManagerProfileDialogDelegate is about.

Me and tangltom are in charge of ProfileChooserView and ProfileChooserController.

I think UserManagerProfileDialogDelegate is used for the webui container when you select 'Manage People' from ProfileChooserView/ProfileChooserController

This became higher priority and the current target is M64.

This is the macViews implementation based on crrev.com/c/750901

Deleted: download.png 66.6 KB

	download.png 66.6 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff683d4c68b0505229fe56d1bd34e371f1758124

commit ff683d4c68b0505229fe56d1bd34e371f1758124
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Fri Nov 10 10:24:02 2017

[signin][Mac] Using ProfileChooserView on macOS

The profile chooser menu on macOS is implemented with cocoa, with
ProfileChooserController. On Linux and Windows, ProfileChooserView is
used (based on toolkit-views).
This patch adds a feature flag (enabled by default) to use
ProfileChooserView on macOS.
The benefit is to have only one implementation on all 3 platforms.

Bug:  728141 
Change-Id: Idf3099ac698dfa1e286ce23e6852390e8500b4b2
Reviewed-on: https://chromium-review.googlesource.com/750901
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515523}
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/about_flags.cc
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/avatar_button_controller.h
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
[add] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/profile_chooser_bridge_views.h
[add] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/profile_chooser_bridge_views.mm
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/common/chrome_features.cc
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/chrome/common/chrome_features.h
[modify] https://crrev.com/ff683d4c68b0505229fe56d1bd34e371f1758124/tools/metrics/histograms/enums.xml

It looks like this change broke keyboard focus in the profiles menu.

#c9: see  Issue 784235  - next canary should have the fix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1038e2cc11f3b68df6204451aa2ba03b7f615073

commit 1038e2cc11f3b68df6204451aa2ba03b7f615073
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Nov 16 10:45:15 2017

macOS: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (cmd-shift-m), the first
profile (other than the current one) in the list should be highlighted. This should
happens only when opening the menu with the keyboard (and not with the mouse).

This was done with Cocoa implementation: crrev.com/2638853003
It should have been done when moving the profile chooser menu to views-toolkit:
crrev.com/c/750901

Bug:  728141 
Change-Id: I724d08ce626ec88144edabe7d928d8315606fd71
Reviewed-on: https://chromium-review.googlesource.com/771753
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517052}
[modify] https://crrev.com/1038e2cc11f3b68df6204451aa2ba03b7f615073/chrome/browser/ui/cocoa/profiles/profile_chooser_bridge_views.mm

Issue 685668 has been merged into this issue.

 Issue 522151  has been merged into this issue.