New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728137 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 721819

Blocking:
issue 634542



Sign in to add a comment

Enable ImageBitmap color conversion unit tests on Android

Project Member Reported by zakerinasab@chromium.org, May 31 2017

Issue description


As a quick solution to crbug.com/721819, the following unit tests are disabled on Android:

ImageBitmapTest.ImageBitmapColorSpaceConversionHTMLImageElement
ImageBitmapTest.ImageBitmapColorSpaceConversionImageBitmap
ImageBitmapTest.ImageBitmapColorSpaceConversionStaticBitmapImage

These tests must be enabled after the source of problem is identified.
 

Comment 1 by fs...@chromium.org, Oct 12 2017

Given that the original bug is fixed, shouldn't those be reenabled?
The original bug was set to fixed because the tests are disabled on Android. I should investigate if the tests are now passing and then we can re-enable them.
Labels: -Pri-3 Pri-2
Blocking: 634542
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72ce3208c7be9d23ff8dcc46a33106594b117a71

commit 72ce3208c7be9d23ff8dcc46a33106594b117a71
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu Mar 08 18:04:04 2018

Enable ImageBitmap color conversion unit tests on Android

TBR=junov@chromium.org

Bug:  728137 
Change-Id: I96a8e446679f9edda13217f169b273869e7e48b3
Reviewed-on: https://chromium-review.googlesource.com/953252
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541836}
[modify] https://crrev.com/72ce3208c7be9d23ff8dcc46a33106594b117a71/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment