New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Add firmware update tool for Infineon TPMs.

Project Member Reported by mnissler@chromium.org, May 31 2017

Issue description

We need to add a tool that can update Infineon TPM firmware. This can either be:

(1) a custom tool we develop based on documentation and code we have or
(2) Infineon's firmware update tool for Linux.

I've played with the latter and found that it builds and runs at least on Intel hardware. Given that firmware updating is a risky business, I'm leaning towards 2. If we sandbox the updater and make sure it never consumes user-supplied data, this should be safe enough.
 
Cc: vapier@chromium.org
Status: Started (was: Available)
I'll look into making the Infineon firmware updater available via a private ebuild.

CC'ing vapier@ in case he thinks we should do this differently ;-)
Blocking: 722261
an ebuild in chromeos-overlay sounds fine (which would get pulled in via virtual/target-chrome-os), assuming of course the source can't be made public :)
BTW, we will probably need to distribute their (or at least some) license alongside the binary, even if we keep the sources private. 

The license text doesn't distinguish between source and binary forms, and includes both in the Licensed Items. And prohibits to "(ii) remove any copyright notices contained in the Licensed Items". 

Plus, there's also the OpenSSL Toolkit part of the licence which also requires that "Redistributions in binary form must reproduce the above copyright notice, ...".

Hopefully, this all be clarified soon, when we get an update on the licensing terms, incl. whether we have the permission to distribute the sources.

i suspect our licensing logic already handles this as part of the build_image phase.  it'll gather the license info for all packages and generate the licensing html on the fly.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/18d11a2df8be28bde22b03ea0a9f6609aeadfc97

commit 18d11a2df8be28bde22b03ea0a9f6609aeadfc97
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Jul 18 01:32:42 2017

recovery: Handle TPM in failed selftest mode gracefully.

This changes the recovery flow to be aware of TPM failed selftest
mode. In particular, we ignore errors when attempting to set
bGlobalLock and let the recovery flow continue, but we don't allow
developer roots nor do we follow through with installing a fresh
system image. This will allow us to add logic to recover TPMs from
failed selftest mode, but doing so is left to follow-up changes.

BUG=chromium:728130
TEST=Recovery image in failed selftest mode proceeds until after verification.

Change-Id: Ic0447820e4368d2db4f13a4e132be9e2970e8330
Reviewed-on: https://chromium-review.googlesource.com/567004
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/18d11a2df8be28bde22b03ea0a9f6609aeadfc97/recovery/recovery_init.sh
[modify] https://crrev.com/18d11a2df8be28bde22b03ea0a9f6609aeadfc97/recovery/init
[modify] https://crrev.com/18d11a2df8be28bde22b03ea0a9f6609aeadfc97/recovery/messages.sh
[modify] https://crrev.com/18d11a2df8be28bde22b03ea0a9f6609aeadfc97/recovery/localized_text/cros_recovery.grd

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf

commit 2a7e9b84ac69c374112a13fd16fbf7cb996b78bf
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Jul 18 07:32:48 2017

Implement tpmc getversion command.

This command exposes the vendor and TPM firmware version.

BRANCH=none
BUG=chromium:728130
TEST=Builds and tpmc getversion prints plausible results.

Change-Id: Iec556a298e025e10bda00121b40a25d8dc3839d1
Reviewed-on: https://chromium-review.googlesource.com/565287
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/include/tpm1_tss_constants.h
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/utility/tlcl_generator.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/lib/tpm_lite/tlcl.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/lib/tpm2_lite/tlcl.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/lib/tpm_lite/mocked_tlcl.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/lib/tpm_lite/include/tlcl_structures.h
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/include/tpm2_tss_constants.h
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/utility/tpmc.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/tests/tlcl_tests.c
[modify] https://crrev.com/2a7e9b84ac69c374112a13fd16fbf7cb996b78bf/firmware/include/tlcl.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/d15f99f10e048606526cbc1dfbfd48e2fd11beed

commit d15f99f10e048606526cbc1dfbfd48e2fd11beed
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Jul 18 16:47:27 2017

recovery: Run TPM firmware updater.

Invoke the TPM firmware updater from recovery image to update TPM
firmware before locking physical presence.

BUG=chromium:728130
TEST=Only tested against a hacked-up firmware updater yet. Needs validation with devices that allow actual updating.

Change-Id: I43039c690d97fdd7bbbb6553d22d58302b92d304
Reviewed-on: https://chromium-review.googlesource.com/563208
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/d15f99f10e048606526cbc1dfbfd48e2fd11beed/recovery/recovery_init.sh
[modify] https://crrev.com/d15f99f10e048606526cbc1dfbfd48e2fd11beed/recovery/init
[modify] https://crrev.com/d15f99f10e048606526cbc1dfbfd48e2fd11beed/recovery/messages.sh
[modify] https://crrev.com/d15f99f10e048606526cbc1dfbfd48e2fd11beed/recovery/localized_text/cros_recovery.grd

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 18 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ee6615d9f8dccffe3b20c7a339bb9cdec0741a42

commit ee6615d9f8dccffe3b20c7a339bb9cdec0741a42
Author: Andrey Pronin <apronin@chromium.org>
Date: Tue Jul 18 21:26:20 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ConstinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a failed selftest mode, boot, check that
     /dev/tpm0 is present, and GetCapability commands
     succeed.

Change-Id: I56b101850902d1983653bf29c8e0c662a5c7e8a0
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/553422
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/ee6615d9f8dccffe3b20c7a339bb9cdec0741a42/drivers/char/tpm/tpm-interface.c

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/6d0d3b4d84219c16536e47e16202b5d247683872

commit 6d0d3b4d84219c16536e47e16202b5d247683872
Author: Mattias Nissler <mnissler@chromium.org>
Date: Wed Jul 19 22:05:51 2017

Add messages for TPM firmware updater use.

This adds the following messages:
 1. Low battery warning shown while waiting for battery to charge.
 2. Message to show while applying the update.
 3. Update failure message with URL to help article.

BUG=chromium:728130
TEST=Manually trigger messages via display-boot-alert.

Change-Id: I778a32c822aeb6f08af8612acd1dfedbc9cd7613
Reviewed-on: https://chromium-review.googlesource.com/574387
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[add] https://crrev.com/6d0d3b4d84219c16536e47e16202b5d247683872/text/boot_messages/en/update_tpm_firmware_low_battery_charging.txt
[modify] https://crrev.com/6d0d3b4d84219c16536e47e16202b5d247683872/text/boot_messages/cros_bootmsg.grd
[add] https://crrev.com/6d0d3b4d84219c16536e47e16202b5d247683872/text/boot_messages/en/update_tpm_firmware_failure.txt
[add] https://crrev.com/6d0d3b4d84219c16536e47e16202b5d247683872/text/boot_messages/en/update_tpm_firmware.txt
[add] https://crrev.com/6d0d3b4d84219c16536e47e16202b5d247683872/text/boot_messages/en/update_tpm_firmware_low_battery.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/55601266da62a43a74a25553383445743f74d303

commit 55601266da62a43a74a25553383445743f74d303
Author: Mattias Nissler <mnissler@chromium.org>
Date: Wed Jul 19 22:09:22 2017

recovery: Update TPM firmware update strings.

BUG=chromium:728130
TEST=Ran recovery and inspected the strings on screen.

Change-Id: Ia963e9c50af2948e047c1909ce55db89cb798a2a
Reviewed-on: https://chromium-review.googlesource.com/577530
Tested-by: Mattias Nissler <mnissler@chromium.org>
Trybot-Ready: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/55601266da62a43a74a25553383445743f74d303/recovery/recovery_init.sh
[modify] https://crrev.com/55601266da62a43a74a25553383445743f74d303/recovery/init
[modify] https://crrev.com/55601266da62a43a74a25553383445743f74d303/recovery/messages.sh
[modify] https://crrev.com/55601266da62a43a74a25553383445743f74d303/recovery/localized_text/cros_recovery.grd

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/d70373b1fbadc7938ca2700577a0d18e590a2bb7

commit d70373b1fbadc7938ca2700577a0d18e590a2bb7
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Jul 21 15:31:36 2017

recovery: Handle missing TPM firmware update approval

The regular boot flow needs to distinguish this situation. Handle this
condition gracefully in the recovery path as well.

BUG=chromium:728130
TEST=Run recovery with missing approval, confirm that it doesn't fail but regular recovery.

Change-Id: Ia6e6940499916cd05818febe7e8cfd6e2494d2d8
Reviewed-on: https://chromium-review.googlesource.com/575245
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/d70373b1fbadc7938ca2700577a0d18e590a2bb7/recovery/recovery_init.sh

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5840e4936ea87475764f8532e9d5409752552975

commit 5840e4936ea87475764f8532e9d5409752552975
Author: Mattias Nissler <mnissler@chromium.org>
Date: Sat Jul 22 07:09:12 2017

init: Add alerts for TPM firmware updater usage.

BUG=chromium:728130
TEST=Manual

Change-Id: If66a0756c36fe2febcb651cbb6e1dc4f2f2c0198
Reviewed-on: https://chromium-review.googlesource.com/574348
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5840e4936ea87475764f8532e9d5409752552975/init/chromeos-boot-alert

Cc: keta...@chromium.org
Labels: -merge-merged-chromeos-4.4 Merge-Request-61
Need to merge c#13 and c#14 to M61.
Project Member

Comment 16 by sheriffbot@chromium.org, Jul 27 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 28 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/6bdde39a21bcfe84bd2de730a357f93a1f7e544a

commit 6bdde39a21bcfe84bd2de730a357f93a1f7e544a
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Jul 28 18:15:27 2017

recovery: Handle missing TPM firmware update approval

The regular boot flow needs to distinguish this situation. Handle this
condition gracefully in the recovery path as well.

BUG=chromium:728130
TEST=Run recovery with missing approval, confirm that it doesn't fail but regular recovery.

Change-Id: Ia6e6940499916cd05818febe7e8cfd6e2494d2d8
Reviewed-on: https://chromium-review.googlesource.com/575245
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
(cherry picked from commit d70373b1fbadc7938ca2700577a0d18e590a2bb7)
Reviewed-on: https://chromium-review.googlesource.com/592187
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/6bdde39a21bcfe84bd2de730a357f93a1f7e544a/recovery/recovery_init.sh

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1c76dfe7d68c68762a4d3c3ce579339dc9f59c8d

commit 1c76dfe7d68c68762a4d3c3ce579339dc9f59c8d
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Jul 28 18:20:22 2017

init: Add alerts for TPM firmware updater usage.

BUG=chromium:728130
TEST=Manual

Change-Id: If66a0756c36fe2febcb651cbb6e1dc4f2f2c0198
Reviewed-on: https://chromium-review.googlesource.com/574348
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 5840e4936ea87475764f8532e9d5409752552975)
Reviewed-on: https://chromium-review.googlesource.com/592049
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Trybot-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/1c76dfe7d68c68762a4d3c3ce579339dc9f59c8d/init/chromeos-boot-alert

Project Member

Comment 19 by sheriffbot@chromium.org, Jul 31 2017

Cc: jorgelo@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 2 2017

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2b84bec0ae0b4a540ca11830e677e7602ab1c116

commit 2b84bec0ae0b4a540ca11830e677e7602ab1c116
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Aug 02 19:47:52 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: Ic3197e3385a893207f248c4a35cebf2bdbfe6bf3
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/596550
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/2b84bec0ae0b4a540ca11830e677e7602ab1c116/drivers/char/tpm/tpm_tis.c

Project Member

Comment 21 by bugdroid1@chromium.org, Aug 2 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e5e2e86caaabe172c726d4ed54340a0740022f2e

commit e5e2e86caaabe172c726d4ed54340a0740022f2e
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Aug 02 19:47:51 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: I142cad786f4ba83c4a856ddfd6f2f52d8fa37bbd
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/596492
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/e5e2e86caaabe172c726d4ed54340a0740022f2e/drivers/char/tpm/tpm_tis.c

Project Member

Comment 22 by sheriffbot@chromium.org, Aug 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 4 2017

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2327f2b31b21bc35e7104763467c86518e75bfce

commit 2327f2b31b21bc35e7104763467c86518e75bfce
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Aug 04 22:39:10 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: I4962393f69053244422578edae4e69254dfa0488
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/601187
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/2327f2b31b21bc35e7104763467c86518e75bfce/drivers/char/tpm/tpm_tis.c

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 10 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d6a06797fde1082cd970542a99538645994d62b2

commit d6a06797fde1082cd970542a99538645994d62b2
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 10 03:08:01 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: I4962393f69053244422578edae4e69254dfa0488
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/601187
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
(cherry picked from commit 2327f2b31b21bc35e7104763467c86518e75bfce)
Reviewed-on: https://chromium-review.googlesource.com/609426

[modify] https://crrev.com/d6a06797fde1082cd970542a99538645994d62b2/drivers/char/tpm/tpm_tis.c

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 10 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1957537ae4c45eb0983e4156be054e96da91d954

commit 1957537ae4c45eb0983e4156be054e96da91d954
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 10 03:27:23 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: Ic3197e3385a893207f248c4a35cebf2bdbfe6bf3
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/596550
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
(cherry picked from commit 2b84bec0ae0b4a540ca11830e677e7602ab1c116)
Reviewed-on: https://chromium-review.googlesource.com/609424

[modify] https://crrev.com/1957537ae4c45eb0983e4156be054e96da91d954/drivers/char/tpm/tpm_tis.c

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 10 2017

Labels: merge-merged-release-R61-9765.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c8e33a29572da2c8aeac7259814af4ced419ee1d

commit c8e33a29572da2c8aeac7259814af4ced419ee1d
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 10 03:29:50 2017

CHROMIUM: tpm: ignore failed selftest in probe

If a tpm is in failed self-test mode, ContinueSelfTest
command results in TPM_FAILEDSELFTEST error, and probe
fails. The tpm device is not created, and that prevents
the OS from attempting any further recover operations
with the tpm. Instead, ignore the negative result of the
self test, and create the device - the chip is out there,
it's just in the failed state.

BUG=chromium:728130
TEST=put tpm in a (simulated) failed selftest mode, boot,
     check that /dev/tpm0 is present, and GetCapability
     commands succeed.

Change-Id: I142cad786f4ba83c4a856ddfd6f2f52d8fa37bbd
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/596492
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
(cherry picked from commit e5e2e86caaabe172c726d4ed54340a0740022f2e)
Reviewed-on: https://chromium-review.googlesource.com/609425

[modify] https://crrev.com/c8e33a29572da2c8aeac7259814af4ced419ee1d/drivers/char/tpm/tpm_tis.c

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5f456b992bf5c28513e9d0d33c1b96fdd18a9d15

commit 5f456b992bf5c28513e9d0d33c1b96fdd18a9d15
Author: Mattias Nissler <mnissler@chromium.org>
Date: Mon Aug 21 19:52:14 2017

init: Add battery charging message to chromeos-boot-alert

This adds a variant of the low battery message for TPM firmware
updating that covers the case where the battery is low but the charger
is connected.

BUG=chromium:728130
TEST=chromeos-boot-alert update_tpm_firmware_low_battery_charging shows the message.

Change-Id: I3c70d6177784e8c1dd686885c1102af85e9581e8
Reviewed-on: https://chromium-review.googlesource.com/618722
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/5f456b992bf5c28513e9d0d33c1b96fdd18a9d15/init/chromeos-boot-alert

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/133a2ff1a0971ad2090f02d2934da324718d7961

commit 133a2ff1a0971ad2090f02d2934da324718d7961
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Aug 22 00:55:23 2017

recovery: Show battery charging message for TPM firmware updater

In case line power is connected, show a different message indicating
that we're charging the battery and wait for sufficient charge.

BUG=chromium:728130
TEST=Manual: TPM firmware update flow during recovery shows different messages for battery charged less than 10% depending on charger presence.

Change-Id: I45dceb4c0b0e882b1b593e6e6563c21b98b7ed4d
Reviewed-on: https://chromium-review.googlesource.com/618720
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/133a2ff1a0971ad2090f02d2934da324718d7961/recovery/messages.sh
[modify] https://crrev.com/133a2ff1a0971ad2090f02d2934da324718d7961/recovery/recovery_init.sh

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/4db2d4efbecab969839f3a92691329d6c33e4633

commit 4db2d4efbecab969839f3a92691329d6c33e4633
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Aug 22 00:55:23 2017

recovery: Append to the firmware updater log

This ensures that output is appended when both the shell and the
firmware updater binary send output to the file.

BUG=chromium:728130
TEST=tpm-firmware-updater.log written by recovery contains fully intact output from the firmware updater.

Change-Id: I51e31144f0f0bba29d313e4953a3ea03655223a4
Reviewed-on: https://chromium-review.googlesource.com/619187
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/4db2d4efbecab969839f3a92691329d6c33e4633/recovery/recovery_init.sh

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/36a8944e4b4e3af172e323d056491aa82f5f6b2d

commit 36a8944e4b4e3af172e323d056491aa82f5f6b2d
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Aug 22 00:55:24 2017

login: Switch to combined TPM firmware update VPD key.

This adjusts session_manager's code to update the VPD settings for TPM
firmware update to use only a single key whose value carries an
encoding of multiple parameters. So we now need to encode the update
mode properly. While at it, also make sure to retain the dryrun
parameter.

BUG=chromium:728130
TEST=unit tests

Change-Id: I58e71ac890606e3f3ad15a98df22f488de276e7a
Reviewed-on: https://chromium-review.googlesource.com/621689
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/session_manager_impl.h
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/system_utils.h
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/session_manager_impl.cc
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/system_utils_impl.cc
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/system_utils_impl.h
[modify] https://crrev.com/36a8944e4b4e3af172e323d056491aa82f5f6b2d/login_manager/mock_system_utils.h

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/b2b3970923b7971acf78b11d5678ddc3a3a23521

commit b2b3970923b7971acf78b11d5678ddc3a3a23521
Author: Mattias Nissler <mnissler@chromium.org>
Date: Thu Aug 24 00:01:24 2017

Add support for IFX FieldUpgradeInfoRequest2 command

Add tpm_lite library support for the IFX specific TPM_FieldUpgrade
subcommand "FieldUpgradeInfoRequest2". Expose this via tpmc so it can
be used from shell scripts.

BRANCH=none
BUG=chromium:728130
TEST=Builds and tpmc ifxfieldupgradeinfo prints plausible results.

Change-Id: Ie58ebccef7fe90f7fca65d7cd9c78e1f16f9f29a
Reviewed-on: https://chromium-review.googlesource.com/562772
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/include/tpm1_tss_constants.h
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/utility/tlcl_generator.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/lib/tpm_lite/tlcl.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/lib/tpm2_lite/tlcl.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/lib/tpm_lite/mocked_tlcl.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/lib/tpm_lite/include/tlcl_structures.h
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/include/tpm2_tss_constants.h
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/utility/tpmc.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/tests/tlcl_tests.c
[modify] https://crrev.com/b2b3970923b7971acf78b11d5678ddc3a3a23521/firmware/include/tlcl.h

Project Member

Comment 32 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543

commit 2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543
Author: Mattias Nissler <mnissler@chromium.org>
Date: Thu Aug 24 02:04:17 2017

Declare TPM model USE flag.

This adds a USE flag indicating the TPM model for boards that carry an
Infineon TPM.

BUG=chromium:728130
TEST=none

Change-Id: I6ea218f63dcb448f44658cd0b9d8778fa4cf7466
Reviewed-on: https://chromium-review.googlesource.com/628838
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-candy/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-swanky/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-peppy/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-gnawty/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-enguarde/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/baseboard-strago/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-glimmer/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-clapper/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-monroe/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-kip/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/baseboard-oak/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-tricky/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-winky/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-ninja/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-peach/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/baseboard-kunimitsu/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-zako/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-orco/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-sumo/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-wolf/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-leon/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/baseboard-jecht/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-nyan/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-link/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-banjo/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-expresso/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-samus/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-falco/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-quawks/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-daisy/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-mccloud/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-panther/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-squawks/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-heli/make.conf
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/baseboard-auron/profiles/base/make.defaults
[modify] https://crrev.com/2f96ce6ec8ed785a4e3ad4b4505aa9eee3664543/overlay-veyron/profiles/base/make.defaults

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/483d76fbf3a9945c1b5ff9d77eeee95658ca3883

commit 483d76fbf3a9945c1b5ff9d77eeee95658ca3883
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Aug 25 23:51:56 2017

init: Set up /var/log/tpm-firmware-updater.log

Add a log file for the TPM firmware updater to log to, set up log
rotation and have debugd pick up the file.

BUG=chromium:728130
TEST=Manual: /var/log/tpm-firmware-updater.log gets rotated

Change-Id: Ic9bd705161370c71d7064f2fec1f5a55d7e6697b
Reviewed-on: https://chromium-review.googlesource.com/629076
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/483d76fbf3a9945c1b5ff9d77eeee95658ca3883/init/chromeos-cleanup-logs
[modify] https://crrev.com/483d76fbf3a9945c1b5ff9d77eeee95658ca3883/debugd/src/log_tool.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Aug 28 2017

Project Member

Comment 35 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d

commit 61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d
Author: Mattias Nissler <mnissler@chromium.org>
Date: Mon Aug 28 22:24:08 2017

Add a driver script to run the updater.

The script takes care of the following:
  (1) Checking whether we have an IFX TPM
  (2) Locate update firmware image.
  (3) Maintain tracking information on number of attempts in VPD.
  (4) Invoke the updater and parse its progress output.

BUG=chromium:728130
TEST=Manual

Change-Id: I9e2f3e27603e55108d6f57de1923a8259f42e489
Reviewed-on: https://chromium-review.googlesource.com/610459
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d/chromeos-base/infineon-firmware-updater/files/unlimited-log-file-size.patch
[add] https://crrev.com/61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater
[rename] https://crrev.com/61ea2e5b5002c42d46d61f3fc905ce3a4aabc72d/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r2.ebuild

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bbca784f9cb9b4149d5e418a6b4fa31e45b54933

commit bbca784f9cb9b4149d5e418a6b4fa31e45b54933
Author: Mattias Nissler <mnissler@chromium.org>
Date: Mon Aug 28 22:24:08 2017

Add an init script to update TPM firmware on first boot.

This invokes the TPM firmware update driver script during early
userspace boot to perform an update if applicable. If there is an
update, a message screen is shown to the user and the machine gets
rebooted after the process completes.

BUG=chromium:728130
TEST=Manual

Change-Id: Ib99f48d27d2d08e947ec17efa3b2c0db04937711
Reviewed-on: https://chromium-review.googlesource.com/611360
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/bbca784f9cb9b4149d5e418a6b4fa31e45b54933/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/bbca784f9cb9b4149d5e418a6b4fa31e45b54933/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.sh
[rename] https://crrev.com/bbca784f9cb9b4149d5e418a6b4fa31e45b54933/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r3.ebuild
[add] https://crrev.com/bbca784f9cb9b4149d5e418a6b4fa31e45b54933/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.conf

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999

commit c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999
Author: Andrey Pronin <apronin@chromium.org>
Date: Tue Aug 29 07:12:19 2017

infineon-firmware-updater: Add dry-run option to the updater.

When run with -update -dry-run, the updater does everything except
for the actual firmware image update. The option is controlled by
a flag in VPD and can be used to test the workflow.

BUG=chromium:728130
TEST=manual

Change-Id: If8409f6c68610aaf71f85354e23c6e70094fcc26
Reviewed-on: https://chromium-review.googlesource.com/611361
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999/chromeos-base/infineon-firmware-updater/files/dry-run-option.patch
[modify] https://crrev.com/c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater
[rename] https://crrev.com/c9a0bfa98297adf0cf00f2ca8488bf3bf15f9999/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r4.ebuild

Project Member

Comment 38 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6bf568e4ca1072f66ddbcf0808eab3026cd34515

commit 6bf568e4ca1072f66ddbcf0808eab3026cd34515
Author: Andrey Pronin <apronin@chromium.org>
Date: Tue Aug 29 07:12:20 2017

infineon-firmware-updater: Change default owner password used by the updater.

Change the password from "12345678" to 20 zero bytes, used by
cryptohome at the first step of taking ownership.

BUG=chromium:728130
TEST=go through the update

Change-Id: I14ab50aaf8ce7305ffe4c2640ae99f36067e5459
Reviewed-on: https://chromium-review.googlesource.com/612693
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[add] https://crrev.com/6bf568e4ca1072f66ddbcf0808eab3026cd34515/chromeos-base/infineon-firmware-updater/files/change_default_password.patch
[rename] https://crrev.com/6bf568e4ca1072f66ddbcf0808eab3026cd34515/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r5.ebuild
[modify] https://crrev.com/6bf568e4ca1072f66ddbcf0808eab3026cd34515/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild

Project Member

Comment 40 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/08b1fa6f8eb64c9707bd03e6d9877277ad2077b3

commit 08b1fa6f8eb64c9707bd03e6d9877277ad2077b3
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 31 11:52:18 2017

overlays: glados: set TPM model

Add a USE flag specifying the TPM model.

BUG=chromium:728130
BUG=chromium:760800
TEST=build_packages --board=chell; check that updater is present

Change-Id: I64e87f9586978bc97d4cbe5be374b16fb4ad8d68
Reviewed-on: https://chromium-review.googlesource.com/644710
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/08b1fa6f8eb64c9707bd03e6d9877277ad2077b3/baseboard-glados/profiles/base/make.defaults

Project Member

Comment 41 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a9787be987274f37e8804748809aea19c4b175b2

commit a9787be987274f37e8804748809aea19c4b175b2
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 31 11:52:21 2017

infineon-firmware-updater: wait for reboot

After reboot command is issued, the system may continue running for
some time until it is actually rebooted. To avoid proceeding to
initializing daemons that depend on tpm after the firmware has been
updated (or update was interrupted), sleep after reboot.

BUG=chromium:759566
BUG=chromium:728130
TEST=go through tpm update, successfully own the device

Change-Id: I5fddf29cc642dda4c989489bb5148052b447185f
Reviewed-on: https://chromium-review.googlesource.com/642548
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[rename] https://crrev.com/a9787be987274f37e8804748809aea19c4b175b2/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r9.ebuild
[modify] https://crrev.com/a9787be987274f37e8804748809aea19c4b175b2/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.sh

Project Member

Comment 42 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7a485489528f2ed7714bd24d553c0e7e0f55fe0f

commit 7a485489528f2ed7714bd24d553c0e7e0f55fe0f
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 31 13:52:00 2017

overlays: kevin: set TPM model

Add a USE flag specifying the TPM model.

BUG=chromium:728130
BUG=chromium:760800
TEST=build_packages --board=kevin; check that updater is present

Change-Id: Iff41563980c2a0152864947d788d2221c9569a5e
Reviewed-on: https://chromium-review.googlesource.com/644157
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/7a485489528f2ed7714bd24d553c0e7e0f55fe0f/overlay-kevin/profiles/base/make.defaults

Project Member

Comment 43 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4189ed9f57367c6fabae0c247154da97a763e304

commit 4189ed9f57367c6fabae0c247154da97a763e304
Author: Andrey Pronin <apronin@chromium.org>
Date: Thu Aug 31 21:19:57 2017

overlays: kevin: fix TPM model

Specify the right TPM model in the USE flags.

BUG=chromium:728130
BUG=chromium:760800
TEST=none

Change-Id: I3d532eb71900c9566296a09d2b78175cd3b16f0f
Reviewed-on: https://chromium-review.googlesource.com/646448
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/4189ed9f57367c6fabae0c247154da97a763e304/overlay-kevin/profiles/base/make.defaults

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2614419f3c430398b999fe638fc22ea1cf3509a8

commit 2614419f3c430398b999fe638fc22ea1cf3509a8
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Sep 04 16:53:36 2017

pushimage: move parser creation into a helper func

No real changes here.  Makes it easier to read and aligns better with
other chromite scripts.

BUG=chromium:728130
TEST=`./scripts/pushimage_unittest` & precq passes

Change-Id: I1b38cfbb2a1d606ee65c936f2357107e7562661e
Reviewed-on: https://chromium-review.googlesource.com/647780
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/2614419f3c430398b999fe638fc22ea1cf3509a8/scripts/pushimage.py

Project Member

Comment 45 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/docs/+/ffc3b8543087a6628db407be320ecf99cd4c4d36

commit ffc3b8543087a6628db407be320ecf99cd4c4d36
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Sep 05 05:35:05 2017

Project Member

Comment 46 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9c325a3b848781185356c067565482e1f1802495

commit 9c325a3b848781185356c067565482e1f1802495
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 04:21:40 2017

infineon-firmware-updater: fix clearing owner for recovery

When updating the firmware in recovery mode, the tpm ownership must be
cleared before the update. Otherwise, it fails. On the other hand, the
ownership is not taken by the update itself, so requesting clearing the
owner on the next boot is not needed.

BUG=chromium:728130
BUG=chromium:762934
TEST=go through tpm powerwash-based update, successfully own the device

Change-Id: Ic5ed14e5853e1480c243f69838a670c5d1560ee0
Reviewed-on: https://chromium-review.googlesource.com/654297
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[rename] https://crrev.com/9c325a3b848781185356c067565482e1f1802495/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r10.ebuild
[modify] https://crrev.com/9c325a3b848781185356c067565482e1f1802495/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater

Project Member

Comment 47 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9951bb7798a92a4cbb25ad54a283b9961003c45b

commit 9951bb7798a92a4cbb25ad54a283b9961003c45b
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:43:38 2017

Declare TPM model USE flag.

This adds a USE flag indicating the TPM model for boards that carry an
Infineon TPM.

BUG=chromium:728130
TEST=none

Reviewed-on: https://chromium-review.googlesource.com/628838
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

BUG=chromium:761803

Change-Id: I24fc6407df9b3d39c90a8138457bcd23659e614a
Reviewed-on: https://chromium-review.googlesource.com/657406
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-candy/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-swanky/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-peppy/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-gnawty/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-enguarde/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/baseboard-strago/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-glimmer/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-clapper/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-monroe/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-kip/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/baseboard-oak/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-tricky/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-winky/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-ninja/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-peach/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/baseboard-kunimitsu/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-zako/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-orco/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-sumo/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-wolf/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-leon/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/baseboard-jecht/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-nyan/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-link/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-banjo/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-expresso/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-samus/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-falco/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-quawks/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-daisy/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-mccloud/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-panther/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-squawks/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-heli/make.conf
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/baseboard-auron/profiles/base/make.defaults
[modify] https://crrev.com/9951bb7798a92a4cbb25ad54a283b9961003c45b/overlay-veyron/profiles/base/make.defaults

Project Member

Comment 48 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/455684f9c82841fccdb9ce877aefa911e2a1ddd9

commit 455684f9c82841fccdb9ce877aefa911e2a1ddd9
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:43:40 2017

overlays: glados: set TPM model

Add a USE flag specifying the TPM model.

BUG=chromium:728130
BUG=chromium:760800
TEST=build_packages --board=chell; check that updater is present

Reviewed-on: https://chromium-review.googlesource.com/644710
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: I1361a27e1f8e91258fe7b2850362fcf0930d19fc
Reviewed-on: https://chromium-review.googlesource.com/657407
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/455684f9c82841fccdb9ce877aefa911e2a1ddd9/baseboard-glados/profiles/base/make.defaults

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f8e233efff34ca331c75a8242079be7812067cf9

commit f8e233efff34ca331c75a8242079be7812067cf9
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:43:42 2017

overlays: kevin: set TPM model

Add a USE flag specifying the TPM model.

BUG=chromium:728130
BUG=chromium:760800
TEST=build_packages --board=kevin; check that updater is present

Reviewed-on: https://chromium-review.googlesource.com/644157
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: Iebe87305512987564459945e74ace6fb60fba46d
Reviewed-on: https://chromium-review.googlesource.com/657408
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/f8e233efff34ca331c75a8242079be7812067cf9/overlay-kevin/profiles/base/make.defaults

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d3492d0e7655a477fcb6e39d29a6b52fec4881a2

commit d3492d0e7655a477fcb6e39d29a6b52fec4881a2
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:43:45 2017

overlays: kevin: fix TPM model

Specify the right TPM model in the USE flags.

BUG=chromium:728130
BUG=chromium:760800
TEST=none

Reviewed-on: https://chromium-review.googlesource.com/646448
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: I5084d528512449350dc2f0501335f8b5d6b927e4
Reviewed-on: https://chromium-review.googlesource.com/657409
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/d3492d0e7655a477fcb6e39d29a6b52fec4881a2/overlay-kevin/profiles/base/make.defaults

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/aab52651d3df11c6a7908e1d07bd81a98d38bea7

commit aab52651d3df11c6a7908e1d07bd81a98d38bea7
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:43:52 2017

Add support for IFX FieldUpgradeInfoRequest2 command

Add tpm_lite library support for the IFX specific TPM_FieldUpgrade
subcommand "FieldUpgradeInfoRequest2". Expose this via tpmc so it can
be used from shell scripts.

BRANCH=none
BUG=chromium:728130
TEST=Builds and tpmc ifxfieldupgradeinfo prints plausible results.

Reviewed-on: https://chromium-review.googlesource.com/562772
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: I80cf4d82de34e5010393918df2a317ea62e17095
Reviewed-on: https://chromium-review.googlesource.com/657427
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/include/tpm1_tss_constants.h
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/utility/tlcl_generator.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/lib/tpm_lite/tlcl.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/lib/tpm2_lite/tlcl.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/lib/tpm_lite/mocked_tlcl.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/lib/tpm_lite/include/tlcl_structures.h
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/include/tpm2_tss_constants.h
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/utility/tpmc.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/tests/tlcl_tests.c
[modify] https://crrev.com/aab52651d3df11c6a7908e1d07bd81a98d38bea7/firmware/include/tlcl.h

Project Member

Comment 52 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e

commit 5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:43:55 2017

Add infineon-firmware-updater package.

BUG=chromium:728130
TEST=builds and runs on samus and veyron_minnie

Reviewed-on: https://chromium-review.googlesource.com/610458
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

BUG=chromium:761803

Change-Id: I7a8459d7838028324442d45efe844ed13871bc86
Reviewed-on: https://chromium-review.googlesource.com/657428
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/licenses/LICENSE.infineon-firmware-updater-TCG
[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/chromeos-base/infineon-firmware-updater/files/makefile-fixes.patch
[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/licenses/BSD-Infineon
[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r1.ebuild
[add] https://crrev.com/5f479a426b4a17f3bc01f7d7dcd9ff4781ca4e2e/chromeos-base/infineon-firmware-updater/Manifest

Project Member

Comment 53 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bc8f20b6905c00ad6d4953040a01b6f671669bef

commit bc8f20b6905c00ad6d4953040a01b6f671669bef
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:43:58 2017

Add a driver script to run the updater.

The script takes care of the following:
  (1) Checking whether we have an IFX TPM
  (2) Locate update firmware image.
  (3) Maintain tracking information on number of attempts in VPD.
  (4) Invoke the updater and parse its progress output.

BUG=chromium:728130
TEST=Manual

Reviewed-on: https://chromium-review.googlesource.com/610459
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: I71a0f2408c2c6938c9b6c48fe4ccec9faae553fc
Reviewed-on: https://chromium-review.googlesource.com/657429
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/bc8f20b6905c00ad6d4953040a01b6f671669bef/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/bc8f20b6905c00ad6d4953040a01b6f671669bef/chromeos-base/infineon-firmware-updater/files/unlimited-log-file-size.patch
[add] https://crrev.com/bc8f20b6905c00ad6d4953040a01b6f671669bef/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater
[rename] https://crrev.com/bc8f20b6905c00ad6d4953040a01b6f671669bef/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r2.ebuild

Project Member

Comment 54 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c5447eaf26df6508944e23d235bd57e770ee64c6

commit c5447eaf26df6508944e23d235bd57e770ee64c6
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:01 2017

Add an init script to update TPM firmware on first boot.

This invokes the TPM firmware update driver script during early
userspace boot to perform an update if applicable. If there is an
update, a message screen is shown to the user and the machine gets
rebooted after the process completes.

BUG=chromium:728130
TEST=Manual

Reviewed-on: https://chromium-review.googlesource.com/611360
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: I87a707bd5e9fe897b4d8d232a9d685e50b7fffaa
Reviewed-on: https://chromium-review.googlesource.com/657430
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/c5447eaf26df6508944e23d235bd57e770ee64c6/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/c5447eaf26df6508944e23d235bd57e770ee64c6/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.sh
[rename] https://crrev.com/c5447eaf26df6508944e23d235bd57e770ee64c6/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r3.ebuild
[add] https://crrev.com/c5447eaf26df6508944e23d235bd57e770ee64c6/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.conf

Project Member

Comment 55 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/97ad10c45c1c053d42dbd0b48d5479b135ef45c3

commit 97ad10c45c1c053d42dbd0b48d5479b135ef45c3
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:44:03 2017

infineon-firmware-updater: Add dry-run option to the updater.

When run with -update -dry-run, the updater does everything except
for the actual firmware image update. The option is controlled by
a flag in VPD and can be used to test the workflow.

BUG=chromium:728130
TEST=manual

Reviewed-on: https://chromium-review.googlesource.com/611361
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: Ie8b3dcc8949d9386c6f09b3cbd17ffe281db2b50
Reviewed-on: https://chromium-review.googlesource.com/657431
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/97ad10c45c1c053d42dbd0b48d5479b135ef45c3/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild
[add] https://crrev.com/97ad10c45c1c053d42dbd0b48d5479b135ef45c3/chromeos-base/infineon-firmware-updater/files/dry-run-option.patch
[modify] https://crrev.com/97ad10c45c1c053d42dbd0b48d5479b135ef45c3/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater
[rename] https://crrev.com/97ad10c45c1c053d42dbd0b48d5479b135ef45c3/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r4.ebuild

Project Member

Comment 56 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f3028c76d210dd9883e7f6bce1779191888980f4

commit f3028c76d210dd9883e7f6bce1779191888980f4
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:44:06 2017

infineon-firmware-updater: Change default owner password used by the updater.

Change the password from "12345678" to 20 zero bytes, used by
cryptohome at the first step of taking ownership.

BUG=chromium:728130
TEST=go through the update

Reviewed-on: https://chromium-review.googlesource.com/612693
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: I3fdf79366c45d2d73f6e8eaf4f3dec07acaceccb
Reviewed-on: https://chromium-review.googlesource.com/657432
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[add] https://crrev.com/f3028c76d210dd9883e7f6bce1779191888980f4/chromeos-base/infineon-firmware-updater/files/change_default_password.patch
[rename] https://crrev.com/f3028c76d210dd9883e7f6bce1779191888980f4/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r5.ebuild
[modify] https://crrev.com/f3028c76d210dd9883e7f6bce1779191888980f4/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/17468d327131942ce858b6b9e8c809bbf3e9d275

commit 17468d327131942ce858b6b9e8c809bbf3e9d275
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:09 2017

infineon-firmware-updater: Report TPM firmware update metrics.

BUG=chromium:728130
TEST=Manual: Run through update flow, then check chrome://histograms.

Reviewed-on: https://chromium-review.googlesource.com/635764
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: I15c2f55bce80464a887591ce254bf7293a0cb737
Reviewed-on: https://chromium-review.googlesource.com/657433
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[rename] https://crrev.com/17468d327131942ce858b6b9e8c809bbf3e9d275/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r6.ebuild
[modify] https://crrev.com/17468d327131942ce858b6b9e8c809bbf3e9d275/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.sh
[add] https://crrev.com/17468d327131942ce858b6b9e8c809bbf3e9d275/chromeos-base/infineon-firmware-updater/files/send-tpm-firmware-update-metrics.conf
[modify] https://crrev.com/17468d327131942ce858b6b9e8c809bbf3e9d275/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0.ebuild

Project Member

Comment 58 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/03eb7db2799fd6e5c2158e560912049191dd1744

commit 03eb7db2799fd6e5c2158e560912049191dd1744
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 08 19:44:18 2017

infineon-firmware-updater: wait for reboot

After reboot command is issued, the system may continue running for
some time until it is actually rebooted. To avoid proceeding to
initializing daemons that depend on tpm after the firmware has been
updated (or update was interrupted), sleep after reboot.

BUG=chromium:759566
BUG=chromium:728130
TEST=go through tpm update, successfully own the device

Reviewed-on: https://chromium-review.googlesource.com/642548
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

BUG=chromium:761803

Change-Id: Ibfaaa00b72c355a0816128fb303f474fa43fb1ab
Reviewed-on: https://chromium-review.googlesource.com/657436
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[rename] https://crrev.com/03eb7db2799fd6e5c2158e560912049191dd1744/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r9.ebuild
[modify] https://crrev.com/03eb7db2799fd6e5c2158e560912049191dd1744/chromeos-base/infineon-firmware-updater/files/tpm-firmware-update.sh

Project Member

Comment 59 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/1dfd4e8a7744c01a78eec4b76125e633465d315e

commit 1dfd4e8a7744c01a78eec4b76125e633465d315e
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:21 2017

Updated cros_bootmsg translations.

BUG=chromium:728130
TEST=Manually trigger messages via display-boot-alert.

BUG=chromium:761803

Change-Id: Ifaf5eaed9d6616e8a507912ea5295d6c835c1936
Reviewed-on: https://chromium-review.googlesource.com/657660
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bg/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ko/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ms/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fr/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pl/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/cs/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lt/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-TW/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/id/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/en-GB/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ko/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ta/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ja/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-BR/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/cs/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/it/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/nl/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bg/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/iw/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-CN/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/te/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ta/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/el/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hi/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/iw/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/uk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fr/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/nl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/gu/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fa/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fil/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-TW/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ja/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/en-GB/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/iw/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/uk/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ca/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bn/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ro/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ms/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-CN/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fil/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/tr/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hu/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/da/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fa/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ro/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sv/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es-419/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fil/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/da/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/kn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/iw/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lv/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/da/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ru/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/da/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/nl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/kn/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/uk/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/mr/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fa/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hr/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ca/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sk/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/gu/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/vi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es-419/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/it/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fi/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/id/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ar/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/te/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ml/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fil/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ml/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/id/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-PT/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-PT/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/tr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ms/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/el/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/mr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lt/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/mr/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bg/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/no/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sr/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-PT/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hi/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/th/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ca/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/mr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/de/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-TW/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ja/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/th/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/de/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ml/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ar/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/et/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/de/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sl/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ko/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lt/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/no/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pl/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/kn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sv/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fa/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/el/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/kn/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ja/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/tr/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ar/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sr/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-BR/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/uk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ml/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/en-GB/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ms/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es-419/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ro/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sk/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ru/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/it/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/et/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/no/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/vi/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sl/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ca/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ko/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ru/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/th/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/en-GB/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/cs/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hu/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-BR/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/vi/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/et/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/no/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/gu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lv/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/el/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ta/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ru/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/sk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/bg/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-CN/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/cs/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/id/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/nl/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ar/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/tr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ro/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/gu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/lt/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-BR/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/de/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/zh-TW/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/es-419/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/pt-PT/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/ta/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/it/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hr/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/te/update_tpm_firmware_failure.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/vi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/th/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/hi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/fi/update_tpm_firmware.txt
[add] https://crrev.com/1dfd4e8a7744c01a78eec4b76125e633465d315e/text/boot_messages/
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/e632df5007c70ce28e87456e4b54b35432e5601a

commit e632df5007c70ce28e87456e4b54b35432e5601a
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:24 2017

recovery: Show battery charging message for TPM firmware updater

In case line power is connected, show a different message indicating
that we're charging the battery and wait for sufficient charge.

BUG=chromium:728130
TEST=Manual: TPM firmware update flow during recovery shows different messages for battery charged less than 10% depending on charger presence.

Reviewed-on: https://chromium-review.googlesource.com/618720
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: Ie39b6b8d92c8a239ba34e6fe1ec9a100768c52f0
Reviewed-on: https://chromium-review.googlesource.com/657661
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/e632df5007c70ce28e87456e4b54b35432e5601a/recovery/messages.sh
[modify] https://crrev.com/e632df5007c70ce28e87456e4b54b35432e5601a/recovery/recovery_init.sh

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/e6a79e78b77e70861299ce1ce0a104bf37556798

commit e6a79e78b77e70861299ce1ce0a104bf37556798
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:26 2017

recovery: Append to the firmware updater log

This ensures that output is appended when both the shell and the
firmware updater binary send output to the file.

BUG=chromium:728130
TEST=tpm-firmware-updater.log written by recovery contains fully intact output from the firmware updater.

Reviewed-on: https://chromium-review.googlesource.com/619187
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: I09c71a1c0830040f580b4461a67598b2eb94ad67
Reviewed-on: https://chromium-review.googlesource.com/657662
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/e6a79e78b77e70861299ce1ce0a104bf37556798/recovery/recovery_init.sh

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b503d1106e158806e5f77fbffc4b23556b9fb64a

commit b503d1106e158806e5f77fbffc4b23556b9fb64a
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:34 2017

init: Add battery charging message to chromeos-boot-alert

This adds a variant of the low battery message for TPM firmware
updating that covers the case where the battery is low but the charger
is connected.

BUG=chromium:728130
TEST=chromeos-boot-alert update_tpm_firmware_low_battery_charging shows the message.

Reviewed-on: https://chromium-review.googlesource.com/618722
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

BUG=chromium:761803

Change-Id: I9d162cd0d84a4b92674d29146585b957c2da7bb1
Reviewed-on: https://chromium-review.googlesource.com/657665
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/b503d1106e158806e5f77fbffc4b23556b9fb64a/init/chromeos-boot-alert

Project Member

Comment 63 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e86801443af53ea7fbfff957a3423f7a0ea78dd4

commit e86801443af53ea7fbfff957a3423f7a0ea78dd4
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:38 2017

login: Switch to combined TPM firmware update VPD key.

This adjusts session_manager's code to update the VPD settings for TPM
firmware update to use only a single key whose value carries an
encoding of multiple parameters. So we now need to encode the update
mode properly. While at it, also make sure to retain the dryrun
parameter.

BUG=chromium:728130
TEST=unit tests

Reviewed-on: https://chromium-review.googlesource.com/621689
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

BUG=chromium:761803

Change-Id: Ie528f3292ac8c3fe32e9587596085fa4b47500f5
Reviewed-on: https://chromium-review.googlesource.com/657667
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/session_manager_impl.h
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/system_utils.h
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/session_manager_impl.cc
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/system_utils_impl.cc
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/system_utils_impl.h
[modify] https://crrev.com/e86801443af53ea7fbfff957a3423f7a0ea78dd4/login_manager/mock_system_utils.h

Project Member

Comment 64 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cfc2e5a92814691562a70d09db52be879d174458

commit cfc2e5a92814691562a70d09db52be879d174458
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Sep 08 19:44:41 2017

init: Set up /var/log/tpm-firmware-updater.log

Add a log file for the TPM firmware updater to log to, set up log
rotation and have debugd pick up the file.

BUG=chromium:728130
TEST=Manual: /var/log/tpm-firmware-updater.log gets rotated

Reviewed-on: https://chromium-review.googlesource.com/629076
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

BUG=chromium:761803

Change-Id: Ic208bf18cdb147345bd417f0b4c667564c2d6fae
Reviewed-on: https://chromium-review.googlesource.com/657668
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/cfc2e5a92814691562a70d09db52be879d174458/init/chromeos-cleanup-logs
[modify] https://crrev.com/cfc2e5a92814691562a70d09db52be879d174458/debugd/src/log_tool.cc

Project Member

Comment 65 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6

commit ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6
Author: Mattias Nissler <mnissler@chromium.org>
Date: Sat Sep 09 00:36:05 2017

Updated cros_bootmsg translations.

BUG=chromium:728130
TEST=Manually trigger messages via display-boot-alert.

Change-Id: I7b77e68e8b599aa7bc8613dc62c0b67bedcd60b1
Reviewed-on: https://chromium-review.googlesource.com/650356
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bg/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ko/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ms/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fr/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pl/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/cs/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lt/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-TW/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/id/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/en-GB/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ko/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ta/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ja/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-BR/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/cs/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/it/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/nl/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bg/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/iw/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-CN/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/te/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ta/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/el/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hi/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/iw/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/uk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fr/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/nl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/gu/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fa/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fil/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-TW/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ja/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/en-GB/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/iw/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/uk/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ca/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bn/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ro/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ms/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-CN/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fil/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/tr/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hu/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/da/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fa/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ro/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sv/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es-419/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fil/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/da/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/kn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/iw/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lv/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/da/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ru/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/da/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/nl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/kn/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/uk/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/mr/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fa/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hr/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ca/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sk/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/gu/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/vi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es-419/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/it/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fi/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/id/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ar/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/te/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ml/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fil/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ml/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/id/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-PT/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-PT/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/tr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ms/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/el/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/mr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lt/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/mr/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bg/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/no/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sr/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-PT/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hi/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/th/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ca/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/mr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/de/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-TW/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ja/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/th/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/de/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ml/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ar/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/et/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/de/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sl/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ko/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lt/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/no/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pl/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/kn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sv/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fa/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/el/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/kn/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ja/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/tr/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ar/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sr/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-BR/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/uk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ml/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/en-GB/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ms/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es-419/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ro/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sk/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ru/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/it/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/et/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/no/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/vi/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sl/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ca/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ko/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ru/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/th/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/en-GB/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/cs/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hu/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-BR/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/vi/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/et/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/no/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/gu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lv/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/el/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ta/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ru/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/sk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/bg/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-CN/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/cs/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/id/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/nl/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ar/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/tr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ro/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/gu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/lt/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-BR/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/de/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/zh-TW/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/es-419/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/pt-PT/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/ta/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/it/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hr/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/te/update_tpm_firmware_failure.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/vi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/th/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/hi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6/text/boot_messages/fi/update_tpm_firmware.txt
[add] https://crrev.com/ea146cb1d59e3e7372ae73fc09fa0f6ba
Project Member

Comment 66 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vpd/+/437a6375c95a60f85725d4e11b6fd385001418f5

commit 437a6375c95a60f85725d4e11b6fd385001418f5
Author: Mattias Nissler <mnissler@chromium.org>
Date: Tue Sep 12 13:38:08 2017

Add tpm_firmware_update_params to the set of documented keys.

BUG=chromium:728130
TEST=None
BRANCH=None

Change-Id: I783ae23229bed1121b23edbd6c36c71a8d676b5c
Reviewed-on: https://chromium-review.googlesource.com/657102
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/437a6375c95a60f85725d4e11b6fd385001418f5/util/check_rw_vpd

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7791210813d4904cd3f55609ee18295353d97cbb

commit 7791210813d4904cd3f55609ee18295353d97cbb
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Sep 13 01:16:31 2017

pushimage: add cli option for forcing channels

This makes it easier to run pushimage by hand and send to a custom channel.

BUG=chromium:728130
TEST=`./scripts/pushimage_unittest` & precq passes

Change-Id: I7b8015b05b5fcfcf23c4ab570ac9ca921bcc0b29
Reviewed-on: https://chromium-review.googlesource.com/647781
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/7791210813d4904cd3f55609ee18295353d97cbb/scripts/pushimage.py
[modify] https://crrev.com/7791210813d4904cd3f55609ee18295353d97cbb/scripts/pushimage_unittest.py

Project Member

Comment 68 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6288454f555dfa1fd322ab49f4faacffe56fb273

commit 6288454f555dfa1fd322ab49f4faacffe56fb273
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Sep 13 19:36:15 2017

CHROMIUM: config: build sbs-battery into kernel for exynos

The battery driver is needed for checking the battery
level in recovery images, where we don't load modules.
Switch from building sbs-battery as a module to building
it into the kernel for exynos-based boards.

BUG=chromium:763554
BUG=chromium:728130
TEST=check battery level from recovery image on daisy

Change-Id: I7a90511a5abea1d7922da5b533f3174cab058621
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/664225
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/6288454f555dfa1fd322ab49f4faacffe56fb273/chromeos/config/armel/chromeos-exynos5.flavour.config

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6288454f555dfa1fd322ab49f4faacffe56fb273

commit 6288454f555dfa1fd322ab49f4faacffe56fb273
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Sep 13 19:36:15 2017

CHROMIUM: config: build sbs-battery into kernel for exynos

The battery driver is needed for checking the battery
level in recovery images, where we don't load modules.
Switch from building sbs-battery as a module to building
it into the kernel for exynos-based boards.

BUG=chromium:763554
BUG=chromium:728130
TEST=check battery level from recovery image on daisy

Change-Id: I7a90511a5abea1d7922da5b533f3174cab058621
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/664225
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

[modify] https://crrev.com/6288454f555dfa1fd322ab49f4faacffe56fb273/chromeos/config/armel/chromeos-exynos5.flavour.config

Labels: tpm-update
Status: Fixed (was: Started)
I think it's time to call this fixed. The functionality is there and working. We can handle follow-up work and bug fixes in separate bugs.
Project Member

Comment 72 by bugdroid1@chromium.org, Sep 15 2017

Labels: merge-merged-release-R62-9901.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/16fd8c5afc1c7b52e0b26ce61383a13499045f83

commit 16fd8c5afc1c7b52e0b26ce61383a13499045f83
Author: Andrey Pronin <apronin@chromium.org>
Date: Fri Sep 15 09:25:10 2017

CHROMIUM: config: build sbs-battery into kernel for exynos

The battery driver is needed for checking the battery
level in recovery images, where we don't load modules.
Switch from building sbs-battery as a module to building
it into the kernel for exynos-based boards.

BUG=chromium:763554
BUG=chromium:728130
TEST=check battery level from recovery image on daisy

Change-Id: I7a90511a5abea1d7922da5b533f3174cab058621
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/664225
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 6288454f555dfa1fd322ab49f4faacffe56fb273)
Reviewed-on: https://chromium-review.googlesource.com/667380
Tested-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/16fd8c5afc1c7b52e0b26ce61383a13499045f83/chromeos/config/armel/chromeos-exynos5.flavour.config

Project Member

Comment 73 by sheriffbot@chromium.org, Sep 15 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 74 by bugdroid1@chromium.org, Sep 19 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f95149c93c9972539d12c547f399fad59ecd819f

commit f95149c93c9972539d12c547f399fad59ecd819f
Author: Andrey Pronin <apronin@chromium.org>
Date: Tue Sep 19 15:16:50 2017

infineon-firmware-updater: fix clearing owner for recovery

When updating the firmware in recovery mode, the tpm ownership must be
cleared before the update. Otherwise, it fails. On the other hand, the
ownership is not taken by the update itself, so requesting clearing the
owner on the next boot is not needed.

BUG=chromium:728130
BUG=chromium:762934
TEST=go through tpm powerwash-based update, successfully own the device

Change-Id: Ic5ed14e5853e1480c243f69838a670c5d1560ee0
Reviewed-on: https://chromium-review.googlesource.com/654297
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
(cherry picked from commit 9c325a3b848781185356c067565482e1f1802495)
Reviewed-on: https://chromium-review.googlesource.com/667381
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[rename] https://crrev.com/f95149c93c9972539d12c547f399fad59ecd819f/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r10.ebuild
[modify] https://crrev.com/f95149c93c9972539d12c547f399fad59ecd819f/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater

Project Member

Comment 75 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c03360a1aff58b45fa2c0d0dd2be04dddafcb42f

commit c03360a1aff58b45fa2c0d0dd2be04dddafcb42f
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Sep 20 00:50:04 2017

CHROMIUM: config: build sbs-battery into kernel for exynos

The battery driver is needed for checking the battery
level in recovery images, where we don't load modules.
Switch from building sbs-battery as a module to building
it into the kernel for exynos-based boards.

BUG=chromium:763554
BUG=chromium:728130
TEST=check battery level from recovery image on daisy

Change-Id: I7a90511a5abea1d7922da5b533f3174cab058621
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/664225
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 6288454f555dfa1fd322ab49f4faacffe56fb273)
Reviewed-on: https://chromium-review.googlesource.com/665879

[modify] https://crrev.com/c03360a1aff58b45fa2c0d0dd2be04dddafcb42f/chromeos/config/armel/chromeos-exynos5.flavour.config

Project Member

Comment 76 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b59aed1c1be8395001168876149ffc8b1602ea8c

commit b59aed1c1be8395001168876149ffc8b1602ea8c
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Sep 20 18:23:50 2017

infineon-firmware-updater: fix clearing owner for recovery

When updating the firmware in recovery mode, the tpm ownership must be
cleared before the update. Otherwise, it fails. On the other hand, the
ownership is not taken by the update itself, so requesting clearing the
owner on the next boot is not needed.

BUG=chromium:728130
BUG=chromium:762934
TEST=go through tpm powerwash-based update, successfully own the device

Change-Id: Ic5ed14e5853e1480c243f69838a670c5d1560ee0
Reviewed-on: https://chromium-review.googlesource.com/654297
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
(cherry picked from commit 9c325a3b848781185356c067565482e1f1802495)
Reviewed-on: https://chromium-review.googlesource.com/659777
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Trybot-Ready: Mattias Nissler <mnissler@chromium.org>

[rename] https://crrev.com/b59aed1c1be8395001168876149ffc8b1602ea8c/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r10.ebuild
[modify] https://crrev.com/b59aed1c1be8395001168876149ffc8b1602ea8c/chromeos-base/infineon-firmware-updater/files/tpm-firmware-updater

Labels: Restrict-View-Google
Labels: Merge-Request-62
Filing merge request to M62 for: https://chromium-review.googlesource.com/650356
Project Member

Comment 79 by sheriffbot@chromium.org, Sep 27 2017

Labels: -Merge-Request-62 Hotlist-Merge-Reject Merge-Reject-62
The bug is marked as P3 or Feature. It should not be merged as M62 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bhthompson@chromium.org
bhthompson: CL listed in 78 just adds translations - I should have merged it earlier, but it's already in M61 and M63, so we should definitely have it in M62 as well :-D
Cc: gov...@chromium.org
+govind

We are not taking new strings for 62 at this point so we would typically not be able to merge this sort of thing.

Krishna, if we already have this in 61 and 63, do we effectively also have string translations for 62 or do we need another translation round here?
Re comment #80 - note that the strings in https://chromium-review.googlesource.com/650356 are not part of the regular translation process. These are strings used by the boot screens which are living in a repository on the Chrome OS side. Hence, this doesn't affect Chrome browser at all.
Labels: -Hotlist-Merge-Reject -Merge-Reject-62 Merge-Approved-62
Ah good point, then this is probably fine, the CL already has translations in it. 

If we don't need to do any extra translation rounds then this LGTM. 
Project Member

Comment 84 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/0b6a7d84924b9568d7081f0836507167fbe606ae

commit 0b6a7d84924b9568d7081f0836507167fbe606ae
Author: Mattias Nissler <mnissler@chromium.org>
Date: Thu Sep 28 10:10:04 2017

Updated cros_bootmsg translations.

BUG=chromium:728130
TEST=Manually trigger messages via display-boot-alert.

Change-Id: I7b77e68e8b599aa7bc8613dc62c0b67bedcd60b1
Reviewed-on: https://chromium-review.googlesource.com/650356
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit ea146cb1d59e3e7372ae73fc09fa0f6babc95ba6)
Reviewed-on: https://chromium-review.googlesource.com/689974
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Trybot-Ready: Mattias Nissler <mnissler@chromium.org>

[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bg/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ko/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ms/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fr/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pl/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/cs/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lt/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-TW/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/id/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/en-GB/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ko/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ta/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ja/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-BR/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/cs/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/it/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/nl/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bg/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/iw/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-CN/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/te/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ta/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/el/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hi/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/iw/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/uk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sv/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fr/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/nl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/gu/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fa/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fil/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-TW/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ja/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/en-GB/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/iw/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/uk/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ca/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bn/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ro/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ms/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-CN/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fil/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/tr/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hu/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/da/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fa/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ro/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sv/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es-419/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fil/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/da/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/kn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/iw/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lv/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/da/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ru/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/da/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sl/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/nl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/kn/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/uk/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/mr/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fa/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hr/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ca/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sk/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/gu/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/vi/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es-419/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/it/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fi/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/id/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bn/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ar/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/te/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ml/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fil/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ml/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/id/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-PT/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-PT/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/tr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ms/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/el/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/mr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lt/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/mr/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bg/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/no/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sr/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-PT/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hi/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/th/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ca/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lv/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/mr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/de/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-TW/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ja/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/th/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/de/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ml/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ar/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/et/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/de/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sl/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ko/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lt/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/no/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pl/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/kn/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sv/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fa/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/el/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/kn/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ja/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/tr/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ar/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sr/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-BR/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/uk/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ml/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/en-GB/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ms/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/fr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es-419/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ro/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sk/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ru/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sl/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/it/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/et/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/no/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/vi/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sl/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ca/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ko/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ru/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/th/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/en-GB/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/cs/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hu/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-BR/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/vi/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/et/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/no/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/gu/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lv/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/el/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ta/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ru/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sr/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/sk/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/bg/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-CN/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/cs/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/id/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/nl/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ar/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/tr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ro/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/gu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/lt/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-BR/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/de/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/zh-TW/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/es-419/update_tpm_firmware.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/pt-PT/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/ta/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/it/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hr/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/te/update_tpm_firmware_failure.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hu/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/vi/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/th/update_tpm_firmware_low_battery.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606ae/text/boot_messages/hr/update_tpm_firmware_low_battery_charging.txt
[add] https://crrev.com/0b6a7d84924b9568d7081f0836507167fbe606a
Labels: -Merge-Approved-61 -Merge-Approved-62
Thanks, all merges done now to the best of my knowledge.
Cc: vpalatin@chromium.org puneetster@chromium.org
Project Member

Comment 87 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3a3b2bfdd896e2498e83c827d6ee9884252c81d2

commit 3a3b2bfdd896e2498e83c827d6ee9884252c81d2
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Oct 06 18:33:52 2017

Fix TPM model declaration for daisy

It turns out that while daisy_skate and daisy_spring do have an SLB
9645, daisy/snow has a SLB 9635. Move the USE flag declarations to the
variant build config.

BUG=chromium:728130
TEST=none

Change-Id: I473295760ac10198f7767e116dc5245fcf43a348
Reviewed-on: https://chromium-review.googlesource.com/700001
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/3a3b2bfdd896e2498e83c827d6ee9884252c81d2/overlay-variant-daisy-spring/make.conf
[modify] https://crrev.com/3a3b2bfdd896e2498e83c827d6ee9884252c81d2/overlay-variant-daisy-skate/make.conf
[modify] https://crrev.com/3a3b2bfdd896e2498e83c827d6ee9884252c81d2/overlay-daisy/make.conf

Cc: skare@chromium.org
Cc: shu...@chromium.org
Project Member

Comment 90 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54e1c8a3a6c00706b4baf0926c9abcd262e2941

commit e54e1c8a3a6c00706b4baf0926c9abcd262e2941
Author: Mattias Nissler <mnissler@chromium.org>
Date: Fri Oct 20 08:21:30 2017

Add histogram declarations for TPM firmware update status.

BUG=chromium:728130
TEST=None

Change-Id: Ia3602c4c4cb4256a201ce6fbfd3d85aad0f05cb8
Reviewed-on: https://chromium-review.googlesource.com/721206
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510377}
[modify] https://crrev.com/e54e1c8a3a6c00706b4baf0926c9abcd262e2941/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e54e1c8a3a6c00706b4baf0926c9abcd262e2941/tools/metrics/histograms/histograms.xml

Project Member

Comment 91 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2f83a213c51ce9ee7eb4947f3b1daa2d0333a682

commit 2f83a213c51ce9ee7eb4947f3b1daa2d0333a682
Author: Mattias Nissler <mnissler@chromium.org>
Date: Wed Oct 25 10:58:54 2017

infineon-firmware-updater: Fix "maximum" metrics parameter

The "maximum" parameter should be the largest reported sample value
plus one.

BUG=chromium:728130
TEST=None

Change-Id: I592f7a063709195cf063108377a37ee788c4e072
Reviewed-on: https://chromium-review.googlesource.com/728029
Commit-Ready: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/2f83a213c51ce9ee7eb4947f3b1daa2d0333a682/chromeos-base/infineon-firmware-updater/files/send-tpm-firmware-update-metrics.conf
[rename] https://crrev.com/2f83a213c51ce9ee7eb4947f3b1daa2d0333a682/chromeos-base/infineon-firmware-updater/infineon-firmware-updater-1.1.2459.0-r17.ebuild

Labels: -Restrict-View-Google -Restrict-View-SecurityNotify
Dropping view restrictions, no longer sensitive.

Comment 93 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 94 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment