[MacViews] Wire up TranslateBubbleView |
||||
Issue descriptionTranslateBubbleView::TranslateBubbleView() needs to take an anchor point and pass it through; this shouldn't be too hard.
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6420c5d35738f0560ed1ff706698a7ba13b8d38b commit 6420c5d35738f0560ed1ff706698a7ba13b8d38b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Jun 02 20:22:24 2017 views: wire up translate bubble This is the bubble that shows up with --enable-translate-new-ux. BUG= 728126 Change-Id: Ia4d92eeff2207bc2becf73e017b6642dcad02b10 Reviewed-on: https://chromium-review.googlesource.com/521344 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#476771} [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/cocoa/browser_window_controller.mm [add] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.h [add] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/cocoa/translate/translate_bubble_bridge_views.mm [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/6420c5d35738f0560ed1ff706698a7ba13b8d38b/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc
,
Jun 8 2017
I think we can punt these to a later phase. See Issue 730958 .
,
Jun 8 2017
Translate need to figure out what dialog they actually want. Two are behind (two different) experiments that lapsed a long time ago and the code is rotting. See Issue 607170 (stale views UI) and Issue 507442 (stale Cocoa UI). Related: Issue 726187 Translate on Mac currently uses an InfoBar which isn't "Secondary" UI, and I think we should keep using for the initial MacViews rollout, since taking the launch bug in Issue 507442 to stable isn't under the purview of MacViews/Harmony.
,
Jun 13 2017
Alright, that's legit. I'm going to mark this as "Keep Cocoa" in the tracker.
,
Oct 16 2017
,
Jan 3 2018
I think this can be marked fixed \o/. There is a tracking bug with the remaining translate bubble work in Issue 781134 . I'll have it block issue 730958 as well. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Jun 1 2017