New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 728106 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Improve audio input WebRTC logging

Project Member Reported by grunell@chromium.org, May 31 2017

Issue description

For example, in AudioInputController we log DoCreate and DoRecord, but DoClose only if we ever got a callback. We should log that always.

It would be good to go through this and other classes and ensure we have logs that make sense and are consistent.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124825d929d1713c468a47953d2342b35570136a

commit 124825d929d1713c468a47953d2342b35570136a
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri Jun 16 15:16:05 2017

Additional logging in AudioInputController.

Bug: 728106
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8dac71e3d220b2f5c4f0ce371c47f4128fc11753
Reviewed-on: https://chromium-review.googlesource.com/531364
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Tommi Gunn <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480048}
[modify] https://crrev.com/124825d929d1713c468a47953d2342b35570136a/media/audio/audio_input_controller.cc
[modify] https://crrev.com/124825d929d1713c468a47953d2342b35570136a/media/audio/audio_input_controller_unittest.cc

What's the status here? More work planned in M62?

Sign in to add a comment