Turn Fullscreen WebContents on by default. |
|||||||
Issue descriptionTurn Fullscreen WebContents on by default to see what bugs crop up on trunk and canary.
,
Jun 1 2017
Is this fixed or is there anything else needed?
,
Jun 1 2017
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/466d40a9545e8124e2ce2561146d46aceec23420 commit 466d40a9545e8124e2ce2561146d46aceec23420 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Jun 07 23:26:26 2017 Revert "📺 Enable FullscreenActivity." This reverts commit 1da41371886c46b3e47fefcc20b40b2c569fe460. Reason for revert: Fullscreen is broken (incorrect dimensions, unsupported chrome instance error, etc.) Original change's description: > 📺 Enable FullscreenActivity. > > BUG=728086 > > Change-Id: Ib15f1714abb30b029b6e89facb51343fbfaa96e3 > Reviewed-on: https://chromium-review.googlesource.com/519247 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#476232} TBR=bauerb@chromium.org,mlamouri@chromium.org,peconn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=728086, 729932 Change-Id: I5f3ad685ed6a9c892d498189febaa60aa44d6a3c Reviewed-on: https://chromium-review.googlesource.com/527893 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#477780} [modify] https://crrev.com/466d40a9545e8124e2ce2561146d46aceec23420/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/466d40a9545e8124e2ce2561146d46aceec23420/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java [modify] https://crrev.com/466d40a9545e8124e2ce2561146d46aceec23420/chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java [modify] https://crrev.com/466d40a9545e8124e2ce2561146d46aceec23420/chrome/browser/android/chrome_feature_list.cc
,
Aug 18 2017
Since this was reverted.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce27f47dc6c557bc995f12b963c20f7629b69445 commit ce27f47dc6c557bc995f12b963c20f7629b69445 Author: Peter E Conn <peconn@chromium.org> Date: Fri Aug 18 18:20:20 2017 📺 Enable FullscreenActivity. Enables FullscreenActivity and includes two smaller bugfixes. Bug: 728086 Change-Id: Ib1622de468fcc03d773243f459e41aa518573b90 Reviewed-on: https://chromium-review.googlesource.com/620776 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#495624} [modify] https://crrev.com/ce27f47dc6c557bc995f12b963c20f7629b69445/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java [modify] https://crrev.com/ce27f47dc6c557bc995f12b963c20f7629b69445/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java [modify] https://crrev.com/ce27f47dc6c557bc995f12b963c20f7629b69445/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java [modify] https://crrev.com/ce27f47dc6c557bc995f12b963c20f7629b69445/chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java [modify] https://crrev.com/ce27f47dc6c557bc995f12b963c20f7629b69445/chrome/browser/android/chrome_feature_list.cc
,
Aug 21 2017
Marking this as fixed as it's enabled again \o/
,
Aug 30 2017
Reopening as it's about to be disabled again :-(
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71b9d7a78e6891208bb5a36b085ff7e4e651fd47 commit 71b9d7a78e6891208bb5a36b085ff7e4e651fd47 Author: Peter E Conn <peconn@chromium.org> Date: Wed Aug 30 14:10:54 2017 📺 Disable FullscreenActivity by default. Disabling FullscreenActivity as it conflicts with displaying secure media. See https://crbug.com/759049 Bug: 728086 Change-Id: I756d3f859a2f7f04120a37ec7f6321202cf488e8 Reviewed-on: https://chromium-review.googlesource.com/643191 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#498450} [modify] https://crrev.com/71b9d7a78e6891208bb5a36b085ff7e4e651fd47/chrome/browser/android/chrome_feature_list.cc
,
Aug 30 2017
,
Sep 1 2017
,
Jul 30
Is this still in progress?
,
Aug 2
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2017