"git cl web" on Mac OS X does not open in default browser |
||||||
Issue descriptionAfter installing the latest update of Mac OS X (now on 10.12.5), "git cl web" stopped opening CL in the default browser but instead display some error messages on the command line and then open it in Safari (where I cannot log in as it does not support U2F). Error displayed on the command-line: $ git cl web 0:63: execution error: "https://chromium-review.googlesource.com/519263" doesn’t understand the “open location” message. (-1708) 70:78: execution error: Can’t get application "firefox". (-1728) This looks like the webbrowser.open method of python no longer works.
,
May 31 2017
,
Jun 2 2017
Does this work? $ BROWSER=open git cl web Python is embedding some AppleScript stuff to open the application, but if you provide $BROWSER, it should call that on the command line. `open $URL` does the job just as well.
,
Jun 2 2017
,
Jun 3 2017
Probably related to AppleScript deprecation. Is your default browser the beta channel?
,
Jun 6 2017
#6: I'm on stable. Since this happened just after an OS update, I'd be tempted to say it is unrelated to the version of Chrome but more related to OS update or python update.
,
Jun 6 2017
Workaround in #4 works for me, so I'm going to use this.
,
Jul 26 2017
Issue 749187 has been merged into this issue.
,
Jul 26 2017
Huh, that sucks. It's just using python's default "webbrowswer" package: https://cs.chromium.org/chromium/tools/depot_tools/git_cl.py?l=5632 https://docs.python.org/2/library/webbrowser.html Looks like this is an instance of https://bugs.python.org/issue30392, which reports that it is fixed in the next version of OSX
,
Dec 20
I can no longer reproduce so I'm assuming agable@ was right and this is now fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sdefresne@chromium.org
, May 31 2017