New issue
Advanced search Search tips

Issue 728029 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Do not cache root_window in ScreenRotationAnimator.

Project Member Reported by wutao@chromium.org, May 31 2017

Issue description

Chrome Version: ToT

What steps will reproduce the problem?
(1) Have internal display and external display.
(2) Set the external display to be the primary display.
(3) Start to rotate the internal display and unplug the external display during rotation animation.
(4) Start to rotate the internal display again.

What is the expected result?
The internal display will rotate.

What happens instead?
Does not rotate.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18f66cce628e31fbde34fa521e526fafeab4839

commit c18f66cce628e31fbde34fa521e526fafeab4839
Author: wutao <wutao@chromium.org>
Date: Fri Jun 02 18:11:01 2017

cros: Do not cache |root_window| in ScreenRotationAnimator.

When removing a display the |root_window| might change. The cache does
not work in this situation.

BUG= 728029 
TEST=manual and ScreenRotationAnimatorSmoothAnimationTest.*

Review-Url: https://codereview.chromium.org/2910413002
Cr-Commit-Position: refs/heads/master@{#476723}

[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/display/display_configuration_controller.cc
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/display/display_configuration_controller.h
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/display/display_configuration_controller_unittest.cc
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/rotator/screen_rotation_animator.h
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/test/display_configuration_controller_test_api.cc
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/ash/test/display_configuration_controller_test_api.h
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/c18f66cce628e31fbde34fa521e526fafeab4839/testing/buildbot/filters/ash_unittests_mus.filter

Comment 2 by wutao@chromium.org, Jun 2 2017

Labels: Merge-Request-60
Please tag with appropriate OSs.  Thanks.

Comment 4 by wutao@chromium.org, Jun 3 2017

Labels: OS-Chrome
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 3 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b279cbf120d6f980b40633aa6cb76d8e6af1125

commit 6b279cbf120d6f980b40633aa6cb76d8e6af1125
Author: Qiang Xu <warx@chromium.org>
Date: Mon Jun 05 18:35:54 2017

[merge to m60] cros: Do not cache |root_window| in ScreenRotationAnimator.

Merget to m60 on behalf of wutao

When removing a display the |root_window| might change. The cache does
not work in this situation.

TBR=oshima@chromium.org
BUG= 728029 
TEST=manual and ScreenRotationAnimatorSmoothAnimationTest.*

Review-Url: https://codereview.chromium.org/2910413002
Cr-Original-Commit-Position: refs/heads/master@{#476723}
Review-Url: https://codereview.chromium.org/2919393002 .
Cr-Commit-Position: refs/branch-heads/3112@{#161}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/display/display_configuration_controller.cc
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/display/display_configuration_controller.h
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/display/display_configuration_controller_unittest.cc
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/rotator/screen_rotation_animator.h
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/test/display_configuration_controller_test_api.cc
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/ash/test/display_configuration_controller_test_api.h
[modify] https://crrev.com/6b279cbf120d6f980b40633aa6cb76d8e6af1125/testing/buildbot/filters/ash_unittests_mus.filter

Comment 7 by wutao@chromium.org, Jun 9 2017

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment