Regression: 'Save password' bubble is seen even though Login button is not clicked at instagram.com
Reported by
sans...@etouch.net,
May 31 2017
|
||||||||
Issue descriptionChrome Version: 61.0.3116.0 (Official Build)64a9be37ccf1e29e9e9cc302da2297f2d3661b5d-refs/heads/master@{#475721}-32/64 bit OS: Windows (7,8,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3) Steps: 1. Launch Chrome and navigate to https://www.instagram.com/accounts/login/ 2. Enter invalid/valid username and password and go to another tab 3. Now switch to Instagram tab and observe Actual: Unnecessary 'Save password' bubble is seen after switching between tabs even though Login button is not clicked Expected: 'Save password' bubble should not be seen when Login button is not clicked This is a regression issue broken in M-60, will soon update the bisect info Good build: 60.0.3103.0 Bad build: 60.0.3104.0
,
May 31 2017
thx for the report, will have a look +maxim, vadym fyi
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5787e3c4df8dc3dbcd6f23b59b830ad63152899 commit c5787e3c4df8dc3dbcd6f23b59b830ad63152899 Author: Jochen Eisinger <jochen@chromium.org> Date: Fri Jun 02 15:22:38 2017 Unconditionally return when the password form is still visible BUG= 728028 R=dvadym@chromium.org,kolos@chromium.org Change-Id: I3500a44b7ebbf2d489705930d687f2dd2d97dd86 Reviewed-on: https://chromium-review.googlesource.com/522067 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#476660} [modify] https://crrev.com/c5787e3c4df8dc3dbcd6f23b59b830ad63152899/components/autofill/content/renderer/password_autofill_agent.cc
,
Jun 6 2017
Does this need to be merged?
,
Jun 6 2017
yes
,
Jun 6 2017
,
Jun 6 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
Thanks for the fix. Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch ASAP.
,
Jun 6 2017
confirmed!
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b6f373436136de47387ef35df01e9652fbf0257 commit 1b6f373436136de47387ef35df01e9652fbf0257 Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Jun 06 20:49:26 2017 Unconditionally return when the password form is still visible BUG= 728028 R=dvadym@chromium.org, kolos@chromium.org TBR=jochen@chromium.org (cherry picked from commit c5787e3c4df8dc3dbcd6f23b59b830ad63152899) Change-Id: I3500a44b7ebbf2d489705930d687f2dd2d97dd86 Reviewed-on: https://chromium-review.googlesource.com/522067 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476660} Reviewed-on: https://chromium-review.googlesource.com/526592 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#205} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/1b6f373436136de47387ef35df01e9652fbf0257/components/autofill/content/renderer/password_autofill_agent.cc
,
Jun 7 2017
,
Jun 8 2017
Verified the issue on windows 10, Mac 10.12.5 and Ubuntu 14.04 using chrome beta version #60.0.3112.24 as per comment #0 Observed that "Save password" bubble was not seen when login button was not clicked. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!!
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbb84fd936d665eae716cfc8ea43308a73d2bf35 commit bbb84fd936d665eae716cfc8ea43308a73d2bf35 Author: Jochen Eisinger <jochen@chromium.org> Date: Wed Jun 21 09:00:50 2017 Add regression test for password manager We shouldn't treat multiple XHRs without changes to the password form as a successful submission BUG= 734954 , 728028 R=dvadym@chromium.org Change-Id: I8394bb411f9db8236e452ddaa8e5488da3a7861e Reviewed-on: https://chromium-review.googlesource.com/542775 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481153} [modify] https://crrev.com/bbb84fd936d665eae716cfc8ea43308a73d2bf35/chrome/renderer/autofill/password_autofill_agent_browsertest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, May 31 2017Labels: hasbisect-per-revision
Owner: jochen@chromium.org
Status: Assigned (was: Unconfirmed)