This is a summary bug for experimental work to: 1. enforce a user gesture requirement on beforeinstallprompt.prompt() 2. stop automatic prompting and require a call to beforeinstallprompt.prompt() to show a banner
Spec work bug: https://github.com/w3c/manifest/issues/576
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dafd5fb273d5135cddbd1c70ba16c619d5856b2b commit dafd5fb273d5135cddbd1c70ba16c619d5856b2b Author: dominickn <dominickn@chromium.org> Date: Mon Jun 05 05:12:17 2017 Propagate a user gesture bit for beforeinstallprompt.prompt() This is in preparation for experiments that will enforce a user gesture to call beforeinstallprompt.prompt(). BUG= 728022 Review-Url: https://codereview.chromium.org/2910363002 Cr-Commit-Position: refs/heads/master@{#476944} [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/content/shell/test_runner/app_banner_service.cc [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/content/shell/test_runner/app_banner_service.h [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp [modify] https://crrev.com/dafd5fb273d5135cddbd1c70ba16c619d5856b2b/third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5bed25edfa875b182516849e1d36b64bce464e9 commit c5bed25edfa875b182516849e1d36b64bce464e9 Author: dominickn <dominickn@chromium.org> Date: Fri Jul 07 03:42:47 2017 Remove AppBannerManager::event_request_id(). This was previously used to ensure we did not get a resolution to the beforeinstallpromptevent that didn't match the current request. However, AppBannerManager wipes its weak pointers when the current request finishes, meaning that event_request_id is unneccessary. BUG= 728022 Review-Url: https://codereview.chromium.org/2969163002 Cr-Commit-Position: refs/heads/master@{#484820} [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/android/banners/app_banner_infobar_delegate_android.h [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/android/banners/app_banner_manager_android.cc [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/android/webapps/add_to_homescreen_manager.cc [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/banners/app_banner_infobar_delegate_desktop.h [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/c5bed25edfa875b182516849e1d36b64bce464e9/chrome/browser/banners/app_banner_manager_desktop.cc
We have decided to move ahead with this, closing this out.
Comment 1 by mgiuca@chromium.org
, May 31 2017