led get-swarm broken |
||||
Issue descriptionThere's an issue where url.Parse refuses to parse a url without a scheme:// and yet, the flag validation expects the parameter swarming host to be a hostname instead of a url (which doesn't parse)
,
May 31 2017
I tried: `led 366dadc69f2e4910` `led get-swarm -S chromium-swarm.appspot.com 366dadc69f2e4910` `led get-swarm -S https://chromium-swarm.appspot.com 366dadc69f2e4910` `led get-swarm 366dadc69f2e4910 -S chromium-swarm.appspot.com` `led get-swarm 366dadc69f2e4910 -S https://chromium-swarm.appspot.com` And variations thereof, I finally built my own led with this change to cmd_get_swarm.go (this might be defeating the purpose of the check, so I didn't upload it) - if p.Host != c.swarmingHost { + if p.Host != "" && p.Host != c.swarmingHost {
,
Jun 21 2017
,
Jun 21 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by iannucci@chromium.org
, May 31 2017