Update blink_perf.paint / FrameView::prePaint to use new frame names |
||
Issue descriptionAfter https://chromium.googlesource.com/chromium/src/+/6a5f851291ddd77204a5c18dd72d5fc7c1d30291 the blink_perf.paint FrameView::prePaint metrics are no longer correct: https://chromeperf.appspot.com/report?sid=7d07af91339a1960ffc8ea21d0d91f1a9c8153d58d7bcf59b0b6eccae9beca1d I think we just need to update the perf benchmark to use LocalFrameView::prePaint instead of FrameView::prePaint.
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a99491214b1f217ba868458001bf834f56d6611e commit a99491214b1f217ba868458001bf834f56d6611e Author: Philip Rogers <pdr@chromium.org> Date: Thu Jun 01 15:49:24 2017 Fix blink_perf tests after FrameView rename FrameView was renamed LocalFrameView which broke our perf tests. This patch updates the trace names to use LocalFrameView. The indentation in this patch follows the javascript style guide. The perf unittests (benchmarks.blink_perf_unittest.BlinkPerfTest) had a bug where GetRepresentativeNumber was missing parens which is how this got through. BUG: 728011 Change-Id: I48ec4efd38ec82338143f931364e7d203a0c771c Reviewed-on: https://chromium-review.googlesource.com/520711 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476294} [modify] https://crrev.com/a99491214b1f217ba868458001bf834f56d6611e/third_party/WebKit/PerformanceTests/Paint/resources/paint.js [modify] https://crrev.com/a99491214b1f217ba868458001bf834f56d6611e/third_party/WebKit/PerformanceTests/TestData/append-child-measure-time.html [modify] https://crrev.com/a99491214b1f217ba868458001bf834f56d6611e/third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html [modify] https://crrev.com/a99491214b1f217ba868458001bf834f56d6611e/third_party/WebKit/PerformanceTests/TestData/simple-html-measure-page-load-time.html [modify] https://crrev.com/a99491214b1f217ba868458001bf834f56d6611e/tools/perf/benchmarks/blink_perf_unittest.py
,
Jun 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, May 31 2017Status: Available (was: Untriaged)