LocalFrame::DragImageForSelection should be moved to DragController |
|||||
Issue descriptionLocalFrame::DragImageForSelection() has nothing to do with the core functionalities of a LocalFrame, and is only used by DragController. For code health, we should move this function to DragController.
,
May 31 2017
Hi @xiaochengh, i will take this up and do the required changes. Thanks
,
May 31 2017
Thanks, tanvir.rizvi@. I'm assigning myself as the virtual owner.
,
May 31 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/857d0cf0147891b495e4df5260bb1e51be5e3980 commit 857d0cf0147891b495e4df5260bb1e51be5e3980 Author: tanvir.rizvi <tanvir.rizvi@samsung.com> Date: Thu Jun 08 07:39:01 2017 Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts and add TODO for movement of drag related functionality out of LocalFrame class. These functionalities are independent of core functionality of LocalFrame so these can be moved out of LocalFrame. BUG= 727981 Review-Url: https://codereview.chromium.org/2924013002 Cr-Commit-Position: refs/heads/master@{#477919} [modify] https://crrev.com/857d0cf0147891b495e4df5260bb1e51be5e3980/third_party/WebKit/Source/core/frame/LocalFrame.cpp
,
Jun 8 2017
,
Jun 8 2017
This is still in progress...
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee841c26ab77ca0aebd65ad839167b2178b7ecde commit ee841c26ab77ca0aebd65ad839167b2178b7ecde Author: tanvir.rizvi <tanvir.rizvi@samsung.com> Date: Wed Jun 21 01:41:55 2017 Move drag related functions present in LocalFrame.cpp to correct files. Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(), DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame() to DataTransfer.cpp. Move DragController::DragImageForSelection() to DragController.cpp. BUG= 727981 Review-Url: https://codereview.chromium.org/2950793002 Cr-Commit-Position: refs/heads/master@{#481067} [modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp [modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/page/DragController.cpp
,
Jun 21 2017
Thanks for the work! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xiaoche...@chromium.org
, May 31 2017