New issue
Advanced search Search tips

Issue 727981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

LocalFrame::DragImageForSelection should be moved to DragController

Project Member Reported by xiaoche...@chromium.org, May 31 2017

Issue description

LocalFrame::DragImageForSelection() has nothing to do with the core functionalities of a LocalFrame, and is only used by DragController.

For code health, we should move this function to DragController.

 
Labels: Hotlist-GoodFirstBug
Hi @xiaochengh, i will take this up and do the required changes. Thanks
Thanks, tanvir.rizvi@. I'm assigning myself as the virtual owner.
Owner: xiaoche...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/857d0cf0147891b495e4df5260bb1e51be5e3980

commit 857d0cf0147891b495e4df5260bb1e51be5e3980
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Thu Jun 08 07:39:01 2017

Rename CreateDragImage to CreateDragImageForFrame to avoid name conflicts

Rename CreateDragImage to CreateDragImageForFrame to avoid name
conflicts and add TODO for movement of drag related functionality
out of LocalFrame class.
These functionalities are independent of core functionality of
LocalFrame so these can be moved out of LocalFrame.

BUG= 727981 

Review-Url: https://codereview.chromium.org/2924013002
Cr-Commit-Position: refs/heads/master@{#477919}

[modify] https://crrev.com/857d0cf0147891b495e4df5260bb1e51be5e3980/third_party/WebKit/Source/core/frame/LocalFrame.cpp

Comment 6 by yosin@chromium.org, Jun 8 2017

Cc: xiaoche...@chromium.org
Owner: ----
Status: Fixed (was: Assigned)
Owner: xiaoche...@chromium.org
Status: Assigned (was: Fixed)
This is still in progress...
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee841c26ab77ca0aebd65ad839167b2178b7ecde

commit ee841c26ab77ca0aebd65ad839167b2178b7ecde
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Wed Jun 21 01:41:55 2017

Move drag related functions present in LocalFrame.cpp to correct files.

Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(),
DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame()
to DataTransfer.cpp.
Move DragController::DragImageForSelection() to DragController.cpp.

BUG= 727981 

Review-Url: https://codereview.chromium.org/2950793002
Cr-Commit-Position: refs/heads/master@{#481067}

[modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/ee841c26ab77ca0aebd65ad839167b2178b7ecde/third_party/WebKit/Source/core/page/DragController.cpp

Status: Fixed (was: Assigned)
Thanks for the work!

Sign in to add a comment