New issue
Advanced search Search tips

Issue 727976 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 730686
issue 727917



Sign in to add a comment

Get rid of src/build/find_depot_tools.py

Project Member Reported by mar...@chromium.org, May 31 2017

Issue description

Goal:
- Stop doing tree walking

Most of the uses in src.git are relating to:
- disable breakpad; not necessary anymore
- get a path to gsutil
- use it as a library: download_from_google_storage/upload_to_google_storage, third_party/boto testing_support.super_mox

Some parts can just be dropped.
Libraries could either be copy pasted or referenced in a deterministic way.

Anyhow, the script needs to stop doing directory walking.
 

Comment 1 by d...@chromium.org, May 31 2017

Note that V8 and BoringSSL also have their own versions of this script. Fuchsia seems to also do some walking.

Comment 2 by mar...@chromium.org, May 31 2017

Other packages I've seen being used are:
- subprocess2 in tools/safely-roll-deps.py, which can probably be deleted
- roll_dep_svn, gclient, scm: used by angle&webrtc for their one off rolling script

Executables:
- pylint.py called manually in third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py
- win_toolchain/vs_files in third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py but grep for 'cdb.exe', there's multiple places where this tool is searched for
- win_toolchain/get_toolchain_if_necessary.py in build/vs_toolchain.py.

I'm not sure why VS handling code in depot_tools at all.

native_client_sdk/src/build_tools/buildbot_common.py contains a completely outdated reference to vs2013_files. It's probably unusable at the moment.

Comment 3 by no...@chromium.org, Aug 18 2017

Blocking: 730686

Comment 4 by no...@chromium.org, Aug 18 2017

Blocking: 756945

Comment 5 by no...@chromium.org, Aug 18 2017

Blocking: -756945
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment