New issue
Advanced search Search tips

Issue 727971 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on: View detail
issue 650150
issue 839389

Blocking:
issue 719303


Participants' hotlists:
Hotlist-Bindings-IDLCompiler


Sign in to add a comment

Support "namespace" definition in WebIDL

Project Member Reported by nhiroki@chromium.org, May 31 2017

Issue description

namespace identifier {
  /* namespace_members... */
};

Spec: https://heycam.github.io/webidl/#idl-namespaces
Spec PR: https://github.com/heycam/webidl/pull/121
 
Blocking: 719303
Cc: domenic@chromium.org
yukishiino@, do you have any rough ETA of this feature? I'm thinking to make 'paintWorklet' attribute 'static' ( issue 719303 ) as a stopgap if this needs a long time because this is blocking upstreaming worklet layout tests to the WPT repository ( issue 724907 ).
IIRC, making the attribute 'static' also needs binding changes around the realm (holder?) handling.
Owner: peria@chromium.org
Status: Assigned (was: Available)
peria@ is willing to support IDL namespace.

For static attribute's issue, I've sent out a CL: https://crrev.com/2913403003 , which should land soonish.  Please use static attributes on CSS interface for the time being.

Thank you!! :D
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd4acd522e94c696bb6e1d177e354e0ccc53ba1c

commit fd4acd522e94c696bb6e1d177e354e0ccc53ba1c
Author: Lisa Suzuki <lisabelle@google.com>
Date: Tue Sep 26 02:34:15 2017

idl_parser: Enable "namespace" to be parsed into ASTs

This CL is a 1st step of supporting "namespace" definition in WebIDL.

In order to check if ASTs are made correctly, I made pattern matching tests.

Bug: 727971
Change-Id: I033e9bab2623675f40a9b941cc53cdecef0c186d
Reviewed-on: https://chromium-review.googlesource.com/676692
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Lisa Suzuki <lisabelle@google.com>
Cr-Commit-Position: refs/heads/master@{#504265}
[modify] https://crrev.com/fd4acd522e94c696bb6e1d177e354e0ccc53ba1c/tools/idl_parser/idl_lexer.py
[modify] https://crrev.com/fd4acd522e94c696bb6e1d177e354e0ccc53ba1c/tools/idl_parser/idl_parser.py
[add] https://crrev.com/fd4acd522e94c696bb6e1d177e354e0ccc53ba1c/tools/idl_parser/test_parser/namespace_web.idl

Comment 7 by peria@chromium.org, Nov 20 2017

Blockedon: 650150
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb396f70fdafd36e61eeea88bb174caa95fd8513

commit fb396f70fdafd36e61eeea88bb174caa95fd8513
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Dec 07 07:34:43 2017

bindings: Generate a IDL information collection per component

This CL defines a new set of Web IDL based classes under web_idl/.
Collecitor class is the main API, which reads IDL files and
stacks converted information.

This CL also updates some BUILD.gn files to generate an
intermediate dump file per component, which includes all
information in IDL files in the component.


Bug: 650150, 727971, 579896
Change-Id: Idc98be4485855afc7797b7fc3af21fb7ee68f0ed
Reviewed-on: https://chromium-review.googlesource.com/648534
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522378}
[modify] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/core/BUILD.gn
[modify] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/modules/BUILD.gn
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/generate_web_idl_collection.py
[modify] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/scripts.gni
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/__init__.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/argument.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/attribute.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/callback_function.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/callback_interface.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/collection.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/collector.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/collector_test.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/constant.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/dictionary.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/ecma_script_types.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/enumeration.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/extended_attribute.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/idl_definition_builder.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/idl_types.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/implements.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/interface.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/literal_token.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/namespace.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/operation.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/typedef.py
[add] https://crrev.com/fb396f70fdafd36e61eeea88bb174caa95fd8513/third_party/WebKit/Source/bindings/scripts/web_idl/utilities.py

Comment 9 by peria@chromium.org, May 3 2018

Blockedon: 839389

Comment 10 by peria@chromium.org, May 25 2018

Labels: Hotlist-Bindings-IDLCompiler

Sign in to add a comment