VS 2017 build packages are much bigger now - avoidably so? |
||
Issue descriptionThe size of the VS 2017 packages recently increased by ~78 MB (compressed). This isn't fatal, but it is worth investigating. Initial investigations showed: I looked with windirstat and that showed a 100 MB increased in the total size of DLLs (plus general growth everywhere else). That turns out to be caused primarily by this directory that appeared even though I packaged the 10.0.14393.0 SDK: win_sdk\bin\10.0.15063.0 So yeah, that's a bug in the packaging script. There are a few other 15063 directories that got pulled in. I might try adding better filtering. On the other hand, the issue will go away once we start packaging with 15063 - there won't be an "other" SDK to pull in. This size increase appears when packaging the 10.0.15063.0 SDK so it's probably worth investigating as it probably implies that we are packaging up multiple copies of many of the tools. The VS 2015 package with 10.0.15063.0 also seems to be quite large - almost as big as the VS 2017 package. We may need to ship one more VS 2015 package, for the 10.0.15063.0 SDK so this might be worth investigating. All of these sizes are with the latest packaging script, updated by https://chromium-review.googlesource.com/516442.
,
May 31 2017
With https://chromium-review.googlesource.com/519982 landed the VS 2017 package went from 885,227,056 to 828,817,338 bytes when going from the 14393 SDK to the 15063 SDK - a 56 MB drop. The VS 2015 package went from 809,068,083 to 820,091,542 bytes - an 11 MB increase. This shows that the worst of the bloat was specific to 15063+VS2017 and that it is basically fixed. I'm calling this bug fixed.
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6460371218a734a724df68694975882f22c52d31 commit 6460371218a734a724df68694975882f22c52d31 Author: brucedawson <brucedawson@chromium.org> Date: Thu Jun 15 00:31:12 2017 VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG= 682416 , 727970 , 683729 Review-Url: https://codereview.chromium.org/2938453003 Cr-Commit-Position: refs/heads/master@{#479555} [modify] https://crrev.com/6460371218a734a724df68694975882f22c52d31/build/vs_toolchain.py |
||
►
Sign in to add a comment |
||
Comment 1 by brucedaw...@chromium.org
, May 31 2017