New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727959 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Jun 2017
Cc:
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 712833
issue 712836



Sign in to add a comment

PromoDialog should extend from AlwaysDismissedDialog

Project Member Reported by tedc...@chromium.org, May 30 2017 
If you turn on don't keep activities from Android, force trigger a promo dialog (via various command lines or in code), then hit home.  You'll see an exception logged to the terminal about leaking a window.

AlwaysDismissedDialog handles this case, so we should just extend from it.

Comment 3 by tedc...@chromium.org, Jun 5 2017

Components: UI>Browser>Mobile>SearchWidget
Labels: Merge-Request-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 5 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0

commit 590fdecfe57acdec9863d66a3c2f2e0094c8b0c0
Author: Ted Choc <tedchoc@google.com>
Date: Thu Jun 08 15:55:47 2017

Ensure promo dialogs are dismissed when activities are destroyed.

BUG= 727959 

Review-Url: https://codereview.chromium.org/2921453003
Cr-Original-Commit-Position: refs/heads/master@{#476452}
Review-Url: https://codereview.chromium.org/2930913002 .
Cr-Commit-Position: refs/branch-heads/3112@{#252}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java
[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialog.java
[modify] https://crrev.com/590fdecfe57acdec9863d66a3c2f2e0094c8b0c0/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java

Comment 6 by tedc...@chromium.org, Jun 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment