LocalFrameView::ForceLayoutParentViewIfNeeded can cause lifecycle state to change |
|||||||
Issue descriptionThat method calls UpdateLayout on the parent, which should *not* lead to any changes to the child's lifecycle state. However, when a CHECK was added to verify this, it caused crashes: https://chromium-review.googlesource.com/517435 It's worth looking at intrinsic size calculation for the LayoutReplaced in the parent document; it does appear to reach into the child FrameView: LayoutReplaced::ComputeIntrinsicSizingInfoForReplacedContent -> LayoutReplaced::ComputeIntrinsicSizingInfo The first call is on the LayoutReplaced in the parent document; the second call is on the LayoutEmbeddedObject in the child document.
,
Jun 6 2017
,
Jun 6 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7200acac17a321b76b0f410f1833b7ce6daccfd8 commit 7200acac17a321b76b0f410f1833b7ce6daccfd8 Author: Stefan Zager <szager@chromium.org> Date: Tue Jun 06 23:12:57 2017 Add CHECK to help debug document lifecycle issue. BUG= 727940 R=eae@chromium.org Change-Id: Ic6f322717af6e4966ad4d86cd429535731c3fb4b Reviewed-on: https://chromium-review.googlesource.com/524712 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#477455} [modify] https://crrev.com/7200acac17a321b76b0f410f1833b7ce6daccfd8/third_party/WebKit/Source/core/dom/Document.cpp
,
Jun 7 2017
,
Jun 22 2017
,
Jun 22 2017
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd4a0c2b2a983dc8ce7ed076f1659d2a82b55470 commit fd4a0c2b2a983dc8ce7ed076f1659d2a82b55470 Author: Stefan Zager <szager@chromium.org> Date: Fri Jun 23 01:51:31 2017 Don't reattach layout tree in the middle of layout BUG= 727940 R=pdr@chromium.org Change-Id: Ie54a42a918f8a5fd2b4845dfce6052242740cdbd Reviewed-on: https://chromium-review.googlesource.com/527606 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#481773} [modify] https://crrev.com/fd4a0c2b2a983dc8ce7ed076f1659d2a82b55470/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/fd4a0c2b2a983dc8ce7ed076f1659d2a82b55470/third_party/WebKit/Source/core/frame/LocalFrameView.h [modify] https://crrev.com/fd4a0c2b2a983dc8ce7ed076f1659d2a82b55470/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp
,
Jul 10 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by e...@chromium.org
, Jun 5 2017