New issue
Advanced search Search tips

Issue 727925 link

Starred by 1 user
Status: Archived
Owner:
qyears...@chromium.org
Closed: Jun 2017
Cc:
jeffcarp@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 725186


Sign in to add a comment

Increase the frequency of the wpt-importer runs

Project Member Reported by qyears...@chromium.org, May 30 2017 
Currently, the wpt importer is scheduled to only run once per day; we want to run it more often.

It's currently run infrequently because:
 - The try bots have very limited capacity ( bug 725186 ); the importer monopolizes the try bots for about an hour for every run.
 - The importer creates a lot of noise for the WPT directory owners that it CCs.

We want the importer to run frequently because when the importer is slow, we can hit a situation where there are upstream changes in wpt but a Chromium committer wants to modify a file in Chromium that hasn't been updated; they can't make their change until the file they want to change is synced from upstream to Chromium.

Comment 1 by foolip@chromium.org, May 31 2017 

We currently require both try jobs and a full CQ run, right?

Would it be possible to reduce this in many common cases by something like this?
 - get a recent build from the waterfall
 - run-webkit-tests --reset-expectations only with the tests we see have changed
 - try to send it through CQ

It'd fail sometimes of course and need to fall back to running all the bots.

Comment 2 by qyears...@chromium.org, May 31 2017

Status: Available (was: Unconfirmed)
That does make sense - 
 Quickly filed bug 728287 and  bug 728288  for two specific sub-changes.

Comment 3 by foolip@chromium.org, Jun 1 2017 

Another idea. If all the changes are inside LayoutTests/external/wpt, could we skip certain bots and tests entirely, in particular browser_tests and anything else that's not blazing fast.

We don't do that for LayoutTests, but what are the reasons? Do the same reasons apply to wpt only?

(If testharness.js is modified we'd still have to run more tests.)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/84348dfbe483c9972d5913930467742028ea93b4

commit 84348dfbe483c9972d5913930467742028ea93b4
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Jun 07 15:08:41 2017

Change the wpt-importer scheduler to trigger 4 times per day.

Bug:  727925 
Change-Id: I81794d3b6038c5fd57cb3a0f8343564d13a62d22
Reviewed-on: https://chromium-review.googlesource.com/526782
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/84348dfbe483c9972d5913930467742028ea93b4/masters/master.chromium.infra.cron/master.cfg

Comment 5 by qyears...@chromium.org, Jun 11 2017

Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Comment 6 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 7 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
►

Sign in to add a comment