Some issues observed: 1) Looking for CHROME_HEADLESS, otherwise does 10s prompt waiting for user: https://chromium.googlesource.com/chromium/tools/depot_tools/+/1101645d533f44d3fe650d1635fa4bbe2b6eb716/win_toolchain/get_toolchain_if_necessary.py#259 2) Seems to be recalculating a different hash than the one requested: https://luci-logdog.appspot.com/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8978150189392001248%2F%2B%2Fsteps%2Fgclient_runhooks__with_patch_%2F0%2Fstdout 3) Still using "/b/depot_tools" (likely due to https://chromium.googlesource.com/chromium/src/+/master/build/find_depot_tools.py). (3) may be the cause of (2), since "depot_tools" on these systems may not be versioned with the toolchain hash calculation algorithm. Proposed solution for (3) is to have the recipe install its own "depot_tools" and operate against it. A longer term solution would be to install "depot_tools" as a former DEPS entry in Chromium and reconfigure its related scripts to reference the DEPS'd version.
Filed issue 727976 to work on find_depot_tools specifically.
Issue 728415 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7c125bfce5b34ab7cc522036053b88f82b62c1ca commit 7c125bfce5b34ab7cc522036053b88f82b62c1ca Author: Dan Jacques <dnj@chromium.org> Date: Thu Jun 01 20:00:48 2017 [chromium] Use explicit environment. Chromium core recipe functions will now install and run under a specific explicit environment. All "chromium" module functions are decorated to install and use the environment. Additionally, the "chromium" and "chromium_tryjob" recipes will use the environment for their entire duration. Other recipes that have not been modified will automatically install the environment when invoking "chromium" recipe module commands, and can individually opt to follow suit and perform all of their actions in an environment context. BUG= chromium:727917 TEST=expectations Change-Id: I9a896f0d3232f2470e82c063f7c5f337fdbf3ff5 Reviewed-on: https://chromium-review.googlesource.com/517776 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/run_mb.expected/cros_board.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic__dbg_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/run_gn.expected/custom_gn_path.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_dbg_try.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/api/create_test_runner.expected/failure.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/webview_tester_basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/failure_tryserver.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/add_swarming_layout_tests_via_manual_diff_inspection.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium.expected/isolated_script_test_custom_merge_script_with_args.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/runtest.expected/python_mode.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/gathering_references_no_values.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/steps/sizes_step.expected/basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/syzygy/smoke_test.expected/full_master_client_syzygy_Syzygy_Smoke_Test.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_tsan2.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/android/builder.expected/full_chromium_perf_Android_Builder.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_msan.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/cronet.expected/local_test.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___stable_branch.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/update_clang.expected/basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/linux_tests.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_build_inconclusive_1.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_no_device.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/retest_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN___concurrent_marking.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/runtest.expected/annotate.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_mips.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_blacklisted_devices.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_ios_arm64_release.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/compile.expected/last_revision_pass_not_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_mips_debug.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_tests/tests/steps/dynamic_perf_tests.expected/sharded.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_fail.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/sizes.expected/platform.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/coverage_builder_basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/run_mb.expected/basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/cronet.expected/cronet_try.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/flake.expected/flakiness_swarming_tests.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_too_many_failures_for_retcode.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_win_cov_try.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/no_values.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/remove_system_vrcore_basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/android/perf.expected/missing_device.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/cronet/examples/full.expected/gn_test.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/no_strict_mode_tester_basic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___1.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_libfuzzer_clang_tot.expected/full_chromium_fyi_ClangToTLinuxASanLibfuzzer.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium.expected/gtest_bad_custom_merge_script.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium/tests/compile.expected/official.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/chromium_android/examples/full.expected/tester_other_device_failure_during_recovery.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___interpreted_regexp.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/ios/try.expected/without_patch_success.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/mac.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/skip_swarming_layout_tests_via_manual_diff_doesnt_match.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___future_pass.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/failed_buildbucket_get.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium.expected/msan.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/bad_config.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_ubsan.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json [modify] https://crrev.com/7c125bfce5b34ab7cc522036053b88f82b62c1ca/scripts/slave/recipes/chromium_tryb
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/74d7e13315bf0e31c065b9940d330f6f583f5f6b commit 74d7e13315bf0e31c065b9940d330f6f583f5f6b Author: Dan Jacques <dnj@chromium.org> Date: Thu Jun 01 22:21:25 2017 [auto_update] Add control script, allow disable. Enable a sentinel file to enable/disable "depot_tools" auto-updating. This file, if present, indicates that automatic updating should not occur. Add a simple control script to enable/disable automatic updating. BUG= chromium:727917 TEST=local - Ran locally, --enable, --disable. R=iannucci@chromium.org, maruel@chromium.org, nodir@chromium.org Change-Id: Id30a17586248228849d046f79d7e0bc445d97f97 Reviewed-on: https://chromium-review.googlesource.com/521884 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/74d7e13315bf0e31c065b9940d330f6f583f5f6b/update_depot_tools.bat [modify] https://crrev.com/74d7e13315bf0e31c065b9940d330f6f583f5f6b/update_depot_tools [add] https://crrev.com/74d7e13315bf0e31c065b9940d330f6f583f5f6b/update_depot_tools_toggle.py [modify] https://crrev.com/74d7e13315bf0e31c065b9940d330f6f583f5f6b/.gitignore
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2a622f20ee62c279073e59cf0b283de2aa5534ce commit 2a622f20ee62c279073e59cf0b283de2aa5534ce Author: Dan Jacques <dnj@chromium.org> Date: Fri Jun 02 00:11:04 2017 [win_toolchain] Allow toolchain dir override. Currently, the Windows toolchain is installed in a subdirectory under "depot_tools". Allow this installation destination to be overridden, either by flag (useful for testing) or via environment variable (to be used in Chromium recipe). BUG= chromium:727917 TEST=local - Ran explicitly w/ flag, seems to work. - Ran via Chromium's "vs_toolchain" with and without environment variable override, seems to install correctly. Change-Id: I6b33832d7f099796e23da0548949073c70a17788 Reviewed-on: https://chromium-review.googlesource.com/521663 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/2a622f20ee62c279073e59cf0b283de2aa5534ce/win_toolchain/get_toolchain_if_necessary.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5 commit cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5 Author: Dan Jacques <dnj@chromium.org> Date: Tue Jun 06 21:34:30 2017 Add "depot_tools" to DEPS. Add "depot_tools" to DEPS, and integrate this into "find_depot_tools". This formally establishes Chromium's dependency on the "depot_tools" repository and ensures that Chromium's expectations are versioned alongside "depot_tools"'s revision. Add a hook to forcefully disable the DEPS'd "depot_tools"'s self-update mechanism, which is enabled by default for developers, ensuring that it will remain at the version pinned in DEPS. Finally, update "find_depot_tools" logic to point to the new DEPS'd "depot_tools" directly as a priority preference. Note that other repositories which have their own versions of "find_depot_tools" will have to have their scripts similarly updated. BUG= chromium:727917 TEST=local - Ran `gclient sync`, syncs and disables. - Manually imported "find_depot_tools", successfully finds DEPS'd version. NOTRY=true Change-Id: I11355ac5c55754b76327a74aa1001bfce4b332ed Reviewed-on: https://chromium-review.googlesource.com/522802 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#477414} [modify] https://crrev.com/cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5/DEPS [modify] https://crrev.com/cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5/build/find_depot_tools.py [modify] https://crrev.com/cea92c51ac31ffeb3f7c36ade3d56b6fcaf593b5/third_party/.gitignore
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/13c87602d802d581d874cc38e9d5761bce6dc87e commit 13c87602d802d581d874cc38e9d5761bce6dc87e Author: Dan Jacques <dnj@chromium.org> Date: Wed Jun 07 18:11:27 2017 [chromium] Store Windows toolchain in cache dir. Store the Windows toolchain in a cache directory during Chromium builds. Currently, Windows toolchain is stored relative to "depot_tools". This is both redundant when there are multiple Windows builders and possibly problematic if the filesystem path exceeds the Windows maximum path length. Export the 'DEPOT_TOOLS_WIN_TOOLCHAIN_ROOT' on Windows builds, directing the toolchain into a cache directory named "win_toolchain". BUG= chromium:727917 TEST=expectations Change-Id: Ie428ed714103475398a6bce8261d26b60f05d72c Reviewed-on: https://chromium-review.googlesource.com/527237 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_dbg_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Debug_x64.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/pgo/examples/full.expected/full_chromium_pgo_test_Test_builder.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/smoke_test.expected/full_master_client_syzygy_Syzygy_Smoke_Test.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_disabled.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/syzygy/examples/full.expected/full_master_client_syzygy_Syzygy_Coverage.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium_tests/tests/api/deapply_patch.expected/basic.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/add_layout_tests_via_manual_diff_inspection.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_dbg_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium_tests/tests/api/archive_build.expected/cross_master_trigger.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_task_failure.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win8_rel_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_win32_bisect.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/kasko_official.expected/full_master_client_syzygy_Kasko_Official.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_rel_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_fail.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_compile_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/test_without_targets_not_skipped.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/auto_bisect_staging/examples/full.expected/basic_win64_bisect.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium/api.py [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_win_cov_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/skip_layout_tests_via_manual_diff_doesnt_match.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/coverage.expected/full_master_client_syzygy_Syzygy_Coverage.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_debug__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_win32_bisect.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_win_release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/syzygy/examples/full.expected/full_master_client_syzygy_Syzygy_Debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_clang_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/compile_skipped.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic_fail.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium/tests/runtest.expected/win.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_official_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/syzygy/examples/full.expected/full_master_client_syzygy_Syzygy_Official.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo_x64.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/auto_bisect/examples/full.expected/basic_win64_bisect.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_clang_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win32_release.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/update_clang.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_chromium_trybot.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Release_x64.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_Syzygy_Official.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_rel_try.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__clang_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json [modify] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da2309d0a1c49d2afbb2bc8f5bdf014735930bf1 commit da2309d0a1c49d2afbb2bc8f5bdf014735930bf1 Author: Dan Jacques <dnj@chromium.org> Date: Fri Jun 09 02:41:26 2017 Use DEPS'd "download_from_google_storage". Break the expectation that "download_from_google_storage" script is somewhere in PATH. Now that "depot_tools" is included via DEPS, we can explicitly reference a version of this script that is known to work with the current DEPS. BUG= chromium:727917 TEST=local - Successfully ran `gclient runhooks`. R=dpranke@chromium.org, iannucci@chromium.org Change-Id: I090cd0f83096b1d42069bede23780c3dec5d9e25 Reviewed-on: https://chromium-review.googlesource.com/528370 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> Cr-Commit-Position: refs/heads/master@{#478169} [modify] https://crrev.com/da2309d0a1c49d2afbb2bc8f5bdf014735930bf1/DEPS
This appears to be working, at least in sufficient capacity to close this bug.
Comment 1 by mar...@chromium.org
, May 31 2017