[WPT Export] Only create PRs for Gerrit CLs with reviewers |
||||||
Issue descriptionPeople don't expect the exporter to come along and make a PR before it's sent for reviews, as was the case with this CL: https://chromium-review.googlesource.com/c/517774/
,
Jun 10 2017
Created a CL to verify this: https://chromium-review.googlesource.com/c/530191/
,
Jun 10 2017
The CL didn't work >:( https://github.com/w3c/web-platform-tests/pull/6208
,
Jul 3 2017
,
Jul 3 2017
,
Jul 5 2017
Similar to issue 738891 , should perhaps be fixed as one?
,
Jul 5 2017
The Gerrit API's ChangeInfo object returns a work_in_progress field, which could be useful in fixing this: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info
,
Jul 5 2017
Issue 738891 has been merged into this issue.
,
Jul 5 2017
,
Jul 5 2017
So there are two boolean flags on ChangeInfo we could use: "work_in_progress" "has_review_started" I'm not sure in what cases these can differ, but I'm going to go ahead and make a CL that relies on "has_review_started," since that better approximates the intent behind this issue.
,
Jul 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62e0417223f6821f7ddb849abb5e3b2f864ec0d9 commit 62e0417223f6821f7ddb849abb5e3b2f864ec0d9 Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Thu Jul 06 19:51:56 2017 [WPT Export] Prevent PRs from WIP CLs from being created Originally we were relying on a CL's reviewer list to prevent creating upstream PRs for CLs without reviewers, however in practice that hasn't been working. I believe using the ChangeInfo property has_started_review will be a more solid solution. Bug: 727914 Change-Id: Ibc2e06d46ba3a16bbceda3a271b675769b040c68 Reviewed-on: https://chromium-review.googlesource.com/559836 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#484716} [modify] https://crrev.com/62e0417223f6821f7ddb849abb5e3b2f864ec0d9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/gerrit.py [modify] https://crrev.com/62e0417223f6821f7ddb849abb5e3b2f864ec0d9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py [modify] https://crrev.com/62e0417223f6821f7ddb849abb5e3b2f864ec0d9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
,
Jul 10 2017
Verified that the above crrev.com/c/559836 fixes this. See in logs: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-exporter%2F27001%2F%2B%2Frecipes%2Fsteps%2FExport_Chromium_commits_and_in-flight_CLs_to_WPT%2F0%2Fstdout |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jun 9 2017