New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727913 link

Starred by 3 users
Status: Assigned
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Cc:
benwells@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Windows external protocol handler should warn the user when ShellExecute() fails

Project Member Reported by thestig@chromium.org, May 30 2017 
Copied over from b/1136923 - In chrome/browser/platform_util_win.cc, OpenExternalOnFileThread(), soon to be renamed OpenExternalOnWorkerThread() checks for ShellExecuteA() failures but does not do anything about it.

Comment 1 by grt@chromium.org, May 31 2017

Owner: benwells@chromium.org
Status: Assigned (was: Untriaged)
It looks like this is an issue for all platforms -- platform_util::OpenExternal returns void.

Ben: could you triage and assign? Thanks.

Comment 2 by thestig@chromium.org, May 31 2017 

FWIW, https://codereview.chromium.org/2910323002/ will soon add a reference to this bug.

Comment 3 by benwells@chromium.org, Jun 1 2017

Cc: benwells@chromium.org
Owner: mgiuca@chromium.org
Hmmm ...My first thought is that this is fine. I guess we could show a modal dialog or something like "Gosh, that didn't work!".

Matt - WDYT? I think I'll accept whatever you think.

Comment 4 by mgiuca@chromium.org, Jun 2 2017 

That's fine, let's keep this bug open since we're planning to do work on external protocol handlers. I think showing a dialog would be appropriate.

Comment 5 by elawrence@chromium.org, Nov 16 2017 

If we do show an error if ShellExecute fails, we should also show one if we bail out early before calling ShellExecute because the URL was too long. 

Today, Chrome shows the AppProtocol confirmation dialog before silently failing to execute the URL.
►

Sign in to add a comment