New issue
Advanced search Search tips

Issue 727908 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
OWP-Storage-DevTools


Sign in to add a comment

[IndexedDB] [DevTools] Update 'refresh' right click button on database to update object store view

Project Member Reported by dmu...@chromium.org, May 30 2017

Issue description

Currently it only refreshes object store list.
 

Comment 1 by dmu...@chromium.org, May 30 2017

Components: Platform>DevTools
Labels: Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec

commit 525c53f0d081a4533b6c55d9b2b991ecfc9d2bec
Author: kristipark <kristipark@chromium.org>
Date: Thu Jun 08 20:37:06 2017

Right-click 'Refresh' on database now updates object store view, also fixed IndexedDB view crash.

The crash was being caused by a null pointer exception in the view constructor since _database in Resources.IDBDatabaseTreeElement was not loaded/stored before the view was constructed. Adding a null check before constructing the view stops the exception.

BUG= 727908 ,  728450 

Review-Url: https://codereview.chromium.org/2914293002
Cr-Commit-Position: refs/heads/master@{#478073}

[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-data-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-names-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/resources-panel-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/upgrade-events-expected.txt
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/525c53f0d081a4533b6c55d9b2b991ecfc9d2bec/third_party/WebKit/Source/devtools/front_end/ui/ReportView.js

Status: Fixed (was: Assigned)

Sign in to add a comment