Stop accumulating stats on the Chrome App |
||||||
Issue descriptionCurrently, the plugin calculates the average/max of the performance metrics of each individual frame the stats before reporting it to the Chrome app. The Chrome app then accumulates it again in JavaScript before reporting to the telemetry service. We would like to remove that 2nd pass of accumulation for consistency in metrics evaluation across the Chrome App and our mobile clients.
,
May 31 2017
This change is needed in M60 to correct a performance metrics reporting error that we discovered earlier. This change only affects the Chrome Remote Desktop Chrome App and will not affect the Chrome binary.
,
Jun 1 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/babc3f453986724dcdbc1e4c3c7ffab9c087455a commit babc3f453986724dcdbc1e4c3c7ffab9c087455a Author: kelvinp@chromium.org <kelvinp@chromium.org> Date: Thu Jun 01 18:28:37 2017 Stops accumulating performance statistics on the Chrome App. This CL also fixes a BUILD file error so that JSCompiler can be run. BUG= 727904 Review-Url: https://codereview.chromium.org/2913073002 Cr-Original-Commit-Position: refs/heads/master@{#475753} Review-Url: https://codereview.chromium.org/2915163002 . Cr-Commit-Position: refs/branch-heads/3112@{#100} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/base/js/client_plugin_impl.js [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/base/js/client_session.js [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/base/js/session_logger.js [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/base/js/session_logger_unittest.js [delete] https://crrev.com/101da67741a368c1e658065350dea1c5940f0a0e/remoting/webapp/base/js/stats_accumulator.js [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/build_template.gni [modify] https://crrev.com/babc3f453986724dcdbc1e4c3c7ffab9c087455a/remoting/webapp/files.gni
,
Jun 6 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 31 2017