New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727878 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 727774
issue 767895



Sign in to add a comment

Modify warm cache host selection to use most recent revision available on bot instead of most recently used bot.

Project Member Reported by robert...@chromium.org, May 30 2017

Issue description

After each tryjob run, as part of the report we are capturing (pending blocking bug) the revisions that are:
 - Checked out
 - Latest revision cached.

We should take those into account instead of how recently the cached was used as they may indicate more accurately how much work would be needed to bring the local build to the revision we want to test.

Ideally the revision we want to test should be at or after the currently checked out revision so that we can get incremental compilation, and before the latest revision cached, so that we need to download less code.
 
Cc: chanli@chromium.org lijeffrey@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6e2f50b3503e00389b1defc7b0195cdfb34f03c2

commit 6e2f50b3503e00389b1defc7b0195cdfb34f03c2
Author: Roberto Carrillo <robertocn@google.com>
Date: Mon Jun 12 20:08:34 2017

[Findit] Record last checked out revision, use to select swarmbot.

This change aims to use the information exposed by findit's recipes'
report to better select a swarming bot for findit's tryjobs.

The information we leverage from the recipes' report is:
  - The latest revision available in the local git cache,
  - The currenly checked out revision in bot's working directory (under
    a named cache),
  These are stored by findit into its data store every time a tryjob
  completes successfully.

  Additionally, we use information obtained from swarming, specifically:
  - Whether a bot is available,
  - Whether the bot has a give named cache.

R=chanli,stgao,lijeffrey
BUG=727878

Change-Id: Id6ba49101357b7cd72dde95c9e43880159035a18
Reviewed-on: https://chromium-review.googlesource.com/525112
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/model/test/wf_try_bot_cache_test.py
[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/waterfall/monitor_try_job_pipeline.py
[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/model/wf_try_bot_cache.py
[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/waterfall/test/swarming_util_test.py
[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
[modify] https://crrev.com/6e2f50b3503e00389b1defc7b0195cdfb34f03c2/appengine/findit/waterfall/swarming_util.py

Status: Assigned (was: Started)
Blocking: 767895

Sign in to add a comment