New issue
Advanced search Search tips

Issue 727875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

tools/android/checkstyle/checkstyle.py throwing exception in presubmit bot

Project Member Reported by boliu@chromium.org, May 30 2017

Issue description

Labels: -Pri-3 Pri-2
I'm guessing this is because chromium_presubmit is a linux checkout & the checkstyle download was moved into an android-specific deps_os section last week: https://codereview.chromium.org/2901773006
Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da2bfbbb47cacfdf9487c9e14f4afef0945729b7

commit da2bfbbb47cacfdf9487c9e14f4afef0945729b7
Author: John Budorick <jbudorick@chromium.org>
Date: Wed May 31 01:49:12 2017

[android] Revert hooks_os change for checkstyle.

Checkstyle gets run on Java changes on chromium_presubmit, which uses
a linux checkout.

Bug:  727875 
Change-Id: I640418439735e91fbf5b18b3d5f5a72e5c00648e
Reviewed-on: https://chromium-review.googlesource.com/517978
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475730}
[modify] https://crrev.com/da2bfbbb47cacfdf9487c9e14f4afef0945729b7/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbdcc4931afb03517d3c7f6e6192eafc244a350c

commit bbdcc4931afb03517d3c7f6e6192eafc244a350c
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Oct 09 18:57:09 2017

Restrict checkstyle JAR download to android and linux.

Bug:  727875 , 772741 
Change-Id: Iac36fc9426b2926c78334bedb8bfa0aaec57ab5a
Reviewed-on: https://chromium-review.googlesource.com/707300
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507432}
[modify] https://crrev.com/bbdcc4931afb03517d3c7f6e6192eafc244a350c/DEPS

Status: Fixed (was: Started)

Sign in to add a comment