When implementing cc-side hit testing for touch action, if cc is able to determine the touch action bit, cc should send an IPC to the browser to pass the touch action bit.
I think the goal for this bug has been changed to compute the while-listed touch actions on the cc side.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b14e2a6c88683e6386e8230c3c099a45d774435 commit 2b14e2a6c88683e6386e8230c3c099a45d774435 Author: Hayley Ferr <hayleyferr@chromium.org> Date: Tue Jul 04 17:34:43 2017 Compute the most restricted TouchAction on cc side Within InputHandlerProxy::HitTestTouchEvent, |touch_action| is passed by pointer to EventListenerTypeForTouchStartOrMoveAt. Within EventListenerTypeForTouchStartOrMoveAt, GetMostRestrictedTouchAction is called and returns the most restricted TouchAction for the point that has been touched. This change will ultimately allow cc side to inform browser of the most restricted bit, possibly saving unecessary work from blink. Logic still needed: Sending the restricted TouchAction to browser. Bug: 727866 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4777a71be0097482c13ae93406e22f072abfd9bc Reviewed-on: https://chromium-review.googlesource.com/541457 Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#484135} [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/BUILD.gn [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/input/input_handler.h [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/layers/touch_action_region.cc [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/layers/touch_action_region.h [add] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/layers/touch_action_region_unittest.cc [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/ui/events/blink/input_handler_proxy.cc [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/ui/events/blink/input_handler_proxy.h [modify] https://crrev.com/2b14e2a6c88683e6386e8230c3c099a45d774435/ui/events/blink/input_handler_proxy_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e19e835fec208839d991952f45c89788d9e482c commit 5e19e835fec208839d991952f45c89788d9e482c Author: Hayley Ferr <hayleyferr@chromium.org> Date: Wed Aug 02 20:41:05 2017 Include InputEventAckState in SetWhiteListedTouchAction IPC If a touchstart event is not send to the renderer but we receive a whitelisted touch action, we need to reset the touch actions from the previous touch event sequence and start the touch ack timeout. This change adds the InputEventAckState to the SetWhiteListedTouchAction IPC so the needed changes can be made in a later CL. Bug: 727866 Change-Id: Ib4dbc7caf26c278a67fde2bfbfae0fd39d909fc7 Reviewed-on: https://chromium-review.googlesource.com/598247 Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491486} [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/browser/renderer_host/input/legacy_input_router_impl.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/browser/renderer_host/input/legacy_input_router_impl.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/common/input_messages.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_event_filter.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_event_filter.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_handler_manager.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_handler_manager.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_handler_manager_client.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_handler_wrapper.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/input_handler_wrapper.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/widget_input_handler_manager.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/content/renderer/input/widget_input_handler_manager.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/ui/events/blink/input_handler_proxy.cc [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/ui/events/blink/input_handler_proxy_client.h [modify] https://crrev.com/5e19e835fec208839d991952f45c89788d9e482c/ui/events/blink/input_handler_proxy_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/810fa82b0d376d3120b4c033365d35d5785ee22b commit 810fa82b0d376d3120b4c033365d35d5785ee22b Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Aug 03 18:03:38 2017 Fix missing test that was added while the new input router was written. A new test was added to the legacy_input_router_impl_unittest but wasn't cloned over to the new input_router_impl. Add the missing code. BUG= 727866 Change-Id: Id7df047f173be06e4447d9ff99c383b85f2e3fed Reviewed-on: https://chromium-review.googlesource.com/598545 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#491793} [modify] https://crrev.com/810fa82b0d376d3120b4c033365d35d5785ee22b/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/810fa82b0d376d3120b4c033365d35d5785ee22b/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/810fa82b0d376d3120b4c033365d35d5785ee22b/content/browser/renderer_host/input/input_router_impl_unittest.cc
Comment 1 by xidac...@chromium.org
, Jun 26 2017