New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727855 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 727848

Blocking:
issue 727866



Sign in to add a comment

Add logic in cc to determine the touch action bits

Project Member Reported by xidac...@chromium.org, May 30 2017

Issue description

Based on the set of rects and their corresponding touch action bits that blink passes, cc should try to determine what is the allowed touch action. If cc cannot determine that (such as overlapping regions), cc ask should ask blink to handle it.
 
Blocking: 727866
Blockedon: 727848
Blocking: -727848
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35

commit aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35
Author: Hayley Ferr <hayleyferr@chromium.org>
Date: Fri Jul 14 01:40:59 2017

Send WhiteListedTouchAction from compositor to browser

cc must send the computed whitelisted touch action to the browser. A
new IPC Message (|InputHostMsg_SetWhiteListedTouchAction|) has been
added to complete this communication. The reasoning for this is to
keep |InputHostMsg_SetTouchAction| as the means of communicating
effective touch actions.

Bug:  727855 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ida9e27b4fe222474292f786ea5ab36d799ec3bad
Reviewed-on: https://chromium-review.googlesource.com/562376
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486613}
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/input_router_client.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/legacy_input_router_impl.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/legacy_input_router_impl.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/legacy_input_router_impl_perftest.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/mock_input_router_client.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/mock_input_router_client.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/input/touch_action_filter.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/common/input_messages.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_event_filter.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_event_filter.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_handler_manager.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_handler_manager.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_handler_manager_client.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_handler_wrapper.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/content/renderer/input/input_handler_wrapper.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/ui/events/blink/input_handler_proxy_client.h
[modify] https://crrev.com/aa29bf6c3f09f306b4b8e681aa7d8fb4ecd88d35/ui/events/blink/input_handler_proxy_unittest.cc

Comment 4 by sunxd@chromium.org, Jul 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment