New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 727848 link

Starred by 1 user
Status: Fixed
Owner:
█ hayleyferr@google.com
Last visit > 30 days ago
Closed: Jun 2017
Cc:
flackr@chromium.org
xidac...@chromium.org
sunxd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 716668
issue 727851
issue 727855



Sign in to add a comment

Layer::SetTouchEventHandlerRegion should take a map rather than a region

Project Member Reported by xidac...@chromium.org, May 30 2017 
Right now, Layer::SetTouchEventHandlerRegion takes a Region as its parameter. In order to perform hit testing on cc side, we should change it to take a map<EffectiveTouchActionBits, Region>, where all the rects with the same touch action bits are put into one region.

Comment 1 by xidac...@chromium.org, May 30 2017

Blockedon: 727851

Comment 2 by xidac...@chromium.org, May 30 2017

Cc: -hayleyferr@google.com sunxd@chromium.org
Owner: hayleyferr@google.com

Comment 3 by xidac...@chromium.org, May 30 2017

Blockedon: 727855

Comment 4 by xidac...@chromium.org, May 30 2017

Blocking: 727855

Comment 5 by xidac...@chromium.org, May 30 2017

Blockedon: -727855

Comment 6 by xidac...@chromium.org, May 31 2017

Blockedon: -727851
Blocking: 727851
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ee3a7dae5e458fc6fec44ed606d33b7707f512

commit d9ee3a7dae5e458fc6fec44ed606d33b7707f512
Author: Hayley Ferr <hayleyferr@google.com>
Date: Fri Jun 16 18:21:11 2017

Change Region element in cc side to instead use a TouchActionRegion.

The cc side now stores a TouchActionRegion as opposed just a Region.
TouchActionRegion is a structure that contains both a map of
TouchAction bits to a Region, and a Region that is a union of all
Regions in the map.

Bug:  727848 ,  727851 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic834cfc326ea8008e6ca33f48c527941c130b170
Reviewed-on: https://chromium-review.googlesource.com/517867
Commit-Queue: Hayley Ferr <hayleyferr@google.com>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480103}
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/BUILD.gn
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/layer.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/layer.h
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/layer_impl.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/layer_impl.h
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/layer_unittest.cc
[add] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/touch_action_region.cc
[add] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/layers/touch_action_region.h
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/test/layer_tree_json_parser.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/test/layer_tree_json_parser_unittest.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/trees/debug_rect_history.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/d9ee3a7dae5e458fc6fec44ed606d33b7707f512/content/renderer/gpu/render_widget_compositor.cc

Comment 8 by xidac...@chromium.org, Jun 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment