New issue
Advanced search Search tips

Issue 727828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Implement DispatchPaymentRequestEventError

Project Member Reported by gogerald@chromium.org, May 30 2017

Issue description

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0eb78ec28a754a7edcb2b3044912ac562fd8d63

commit f0eb78ec28a754a7edcb2b3044912ac562fd8d63
Author: gogerald <gogerald@google.com>
Date: Thu Jul 27 16:00:41 2017

[Payments] Fail InvokePaymentApp when there is an error

video:
https://drive.google.com/file/d/0B4yF5XJG4VQAY1Qtck0td2J3Ylk/view?usp=sharing

Bug:  727828 
Change-Id: I9a11121e8683d379567352cc3bba41791c1fdb5a
Reviewed-on: https://chromium-review.googlesource.com/587147
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rob Buis <rob.buis@samsung.com>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489949}
[modify] https://crrev.com/f0eb78ec28a754a7edcb2b3044912ac562fd8d63/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
[modify] https://crrev.com/f0eb78ec28a754a7edcb2b3044912ac562fd8d63/content/browser/payments/payment_app_provider_impl.cc

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c39ab7342873a451b74002d670cc06b069b50d3

commit 6c39ab7342873a451b74002d670cc06b069b50d3
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Aug 01 14:27:45 2017

PaymentHandler: Refactor PaymentAppProviderImpl and InvocationCallback.

This refactoring is intented to share a lot of codes when introducing a new
event dispatching such as CanMakePaymentEvent[1]. Basically, this change
includes the following things:
  - Introduce StartServiceWorkerForDispatch() to use the same logic when adding
    a new event here.
  - There is no reason to create InvocationCallbacks too early. It's better to
    defer the timing just before dispatching event.
  - Add a test for when StartRequest() is failed because ServiceWorker is killed
    for some reasons.

[1] https://chromium-review.googlesource.com/c/574992/

Bug:  727828 
Change-Id: I02a798fa7f9f6854ef8ab424085d3107b5b5f022
Reviewed-on: https://chromium-review.googlesource.com/594607
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490989}
[modify] https://crrev.com/6c39ab7342873a451b74002d670cc06b069b50d3/content/browser/payments/payment_app_browsertest.cc
[modify] https://crrev.com/6c39ab7342873a451b74002d670cc06b069b50d3/content/browser/payments/payment_app_provider_impl.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d448a2700c0ca9d6773519280c1beaf3030cbb

commit a8d448a2700c0ca9d6773519280c1beaf3030cbb
Author: gogerald <gogerald@google.com>
Date: Thu Aug 10 14:18:13 2017

[Payments] Remove unused argument

Bug:  727828 
Change-Id: I97291663f84e8bb1c3c595be9a2e509580e9ee6c
Reviewed-on: https://chromium-review.googlesource.com/609364
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#493379}
[modify] https://crrev.com/a8d448a2700c0ca9d6773519280c1beaf3030cbb/content/browser/payments/payment_app_provider_impl.cc

Sign in to add a comment