New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727827 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Touch Bar: Arrows are placed some pixels too high

Project Member Reported by meh...@chromium.org, May 30 2017

Issue description

I have no MacBookPro with a Touch Bar, but from the screenshot in issue 727776 C#0 the arrows look some pixels to high.

Not sure if it is a bug or intended - just wanted to mention it :-)
 
actual.png
20.1 KB View Download
expected.png
20.3 KB View Download

Comment 1 by shrike@chromium.org, May 30 2017

Labels: -Pri-2 ReleaseBlock-Stable M-60 Pri-1
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Summary: Touch Bar: Arrows are placed some pixels too high (was: Touch Bar: Arrows are placed some pixels to high)
It does look like the arrows are a couple pixels too high.

Looks like this issue is caused by NSSegmentedControl's segmentedControlWithImages, which draws the images 2 px higher than in NSButton.

An easy way for this to do this is to just not just the segmented control and separate the buttons

Otherwise, I'll play around and see if I can hack something
Status: Started (was: Assigned)
Does this look alright?
Screen Shot 2017-05-31 at 4.38.50 PM.png
202 KB View Download

Comment 4 by shrike@chromium.org, May 31 2017

It looks great.
Awesome
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28efe6a5918b0a0cb890b5f93c09f5d1d1216cdf

commit 28efe6a5918b0a0cb890b5f93c09f5d1d1216cdf
Author: spqchan <spqchan@chromium.org>
Date: Tue Jun 06 06:24:51 2017

[Mac] Move Back/Forward Touch Bar Icons 2 pts lower

Bug:  727827 
Change-Id: I814f36a3f2662bcf5b963082e5690b659615f67a
Reviewed-on: https://chromium-review.googlesource.com/520842
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477213}
[modify] https://crrev.com/28efe6a5918b0a0cb890b5f93c09f5d1d1216cdf/chrome/browser/ui/cocoa/browser_window_touch_bar.mm

Comment 7 by abom...@etouch.net, Jun 9 2017

Note: Above issue is fixed on Latest Chrome Version:61.0.3124.4 (Official Build) 2ccba3fd9c04d6ca967808d2fbb9aadbbda5fb6f-refs/branch-heads/3124@{#6}

Thanks

Comment 8 by abom...@etouch.net, Jun 9 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3124.4
Labels: Merge-Request-60
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 9 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/069529d93b28352b81a790469ec6e2beaec7adcc

commit 069529d93b28352b81a790469ec6e2beaec7adcc
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 09 18:18:09 2017

[Mac] Move Back/Forward Touch Bar Icons 2 pts lower

Bug:  727827 
Change-Id: I814f36a3f2662bcf5b963082e5690b659615f67a
Reviewed-on: https://chromium-review.googlesource.com/520842
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477213}
Review-Url: https://codereview.chromium.org/2928183002 .
Cr-Commit-Position: refs/branch-heads/3112@{#287}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/069529d93b28352b81a790469ec6e2beaec7adcc/chrome/browser/ui/cocoa/browser_window_touch_bar.mm

Status: Fixed (was: Started)

Comment 13 by abom...@etouch.net, Jun 14 2017

Note: Above issue is fixed on Latest Beta Chrome Version:60.0.3112.32 (Official Build) 17d6d37b6632cc655909327c7c0559c28bdbf388-refs/branch-heads/3112@{#330}

Thanks
Labels: TE-Verified-M60 TE-Verified-60.0.3112.32
Adding verified labels as per comment #13.

Sign in to add a comment