New issue
Advanced search Search tips

Issue 727812 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 715695



Sign in to add a comment

Move IOThread command line argument handling over to NetworkSessionConfigurator.

Project Member Reported by mmenke@chromium.org, May 30 2017

Issue description

NetworkSessionConfigurator claims to implement command line argument handling, however, it does not.  I want to move handling of (most) command line arguments that affect HttpNetworkSession::Params over to that class, so both the IOThread and NetworkService can easily share it.  Note that basically everything it handles are test-only options and field trials, so I don't think there's a problem promoting it to be a content/ dependency.

It does include data_reduction_proxy_params.h, which it doesn't currently look to be using, variations_associated_data.h (Already used by content/), and version_info.h (Not currently used), so I think to use this at the content/ layer, we can just remove those headers and we're done.

I'm not sure about longer term, though - currently the network_service is in content/, but eventually we'll probably want to move it to its own service, above content/, and not sure if we can depend on components/variations there, but think that's an issue for another day.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68a502104896fc2bb14fc3903afe31d275e2ffda

commit 68a502104896fc2bb14fc3903afe31d275e2ffda
Author: mmenke <mmenke@chromium.org>
Date: Mon Jun 12 20:20:31 2017

Move some of IOThread's command line logic to network_session_configurator.

This will allow it to be shared with the network service, and makes it
easy to pass all relevant arguments to the network service as well.

May add handling for command line arguments that affect more than just
the HttpNetworkSession::Params there as well in a future CL, to enable
further code sharing.

TBR=lcwu@chromium.org,rkc@chromium.org
BUG= 727812 

Review-Url: https://codereview.chromium.org/2914893002
Cr-Commit-Position: refs/heads/master@{#478740}

[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/android_webview/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/android_webview/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/about_flags.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/io_thread.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/payments/site_per_process_payments_browsertest.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/common/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/common/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/common/chrome_switches.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/common/chrome_switches.h
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/common/service_process_util.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/service/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/service/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/service/service_process.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chrome/test/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chromecast/browser/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chromecast/browser/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/BUILD.gn
[delete] https://crrev.com/41757e52bacb2dd4ba55823e49bb16cc96347cb4/components/network_session_configurator/DEPS
[rename] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/browser/BUILD.gn
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/browser/DEPS
[rename] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/browser/network_session_configurator.cc
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/browser/network_session_configurator.h
[rename] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/common/BUILD.gn
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/common/DEPS
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/common/network_switch_list.h
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/common/network_switches.cc
[add] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/components/network_session_configurator/common/network_switches.h
[delete] https://crrev.com/41757e52bacb2dd4ba55823e49bb16cc96347cb4/components/network_session_configurator/network_session_configurator.h
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/browser/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/browser/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/browser/browsing_data/clear_site_data_throttle_browsertest.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/network/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/network/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/network/network_context.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/public/common/content_switches.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/public/common/content_switches.h
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/shell/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/shell/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/shell/browser/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/test/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/content/test/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/extensions/shell/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/extensions/shell/browser/DEPS
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/extensions/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/ios/components/io_thread/BUILD.gn
[modify] https://crrev.com/68a502104896fc2bb14fc3903afe31d275e2ffda/ios/components/io_thread/ios_io_thread.mm

Comment 2 by mmenke@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)

Comment 3 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment