New issue
Advanced search Search tips

Issue 727804 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 724565



Sign in to add a comment

Clean up data races on webkit_unit_tests

Project Member Reported by fs...@chromium.org, May 30 2017

Issue description

To enable webkit_unit_tests on tsan bot, we need to clean up all non-running tests.

See http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2 for the steps to build and run with TSan.

 

Comment 1 by fs...@chromium.org, May 30 2017

Currently problematic tests:

fail: WebFrameTest.TestNonCompositedOverlayScrollbarsFade
timeout: WebFrameTest.MaxFramesDetach
Components: -Blink
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05852d48c8a818e167382d0b5f2ab32229c7b8ed

commit 05852d48c8a818e167382d0b5f2ab32229c7b8ed
Author: Fernando Serboncini <fserb@google.com>
Date: Wed May 31 22:49:39 2017

Disable webkit tests that would fail on TSan

Bug:  727804 
Change-Id: Id1abe87a742136466dd50ffb6e45dc3f98bdbf1d
Reviewed-on: https://chromium-review.googlesource.com/518308
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476076}
[modify] https://crrev.com/05852d48c8a818e167382d0b5f2ab32229c7b8ed/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93932dc8c8355fd719083079ee153f0f953fe767

commit 93932dc8c8355fd719083079ee153f0f953fe767
Author: Fernando Serboncini <fserb@google.com>
Date: Fri Jun 02 00:24:30 2017

Enable webkit_unit_tests on TSan built bot

Depending on:
https://chromium-review.googlesource.com/c/518308/

Bug:  727804 
Change-Id: I70e48bd5336a2fca3e5661ef1df8e03941003a10
Reviewed-on: https://chromium-review.googlesource.com/517675
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476492}
[modify] https://crrev.com/93932dc8c8355fd719083079ee153f0f953fe767/testing/buildbot/chromium.memory.json

Comment 5 by fs...@chromium.org, Jun 28 2017

Status: Fixed (was: Started)

Sign in to add a comment