Screen tearing in VR browser and WebVR |
||||||
Issue descriptionWe're seeing screen tearing in VR mode on Android/GVR/Daydream, this seems to have been triggered by http://crrev.com/725684 / r474122 which enabled using a high priority GL context for VrShellGl. Apparently this causes conflicts with GVR's own internal high priority GL context that it uses for async reprojection. See also b/62140262.
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01693c7c9e98c2a4f3809cb1b4d6ae7b97eab02f commit 01693c7c9e98c2a4f3809cb1b4d6ae7b97eab02f Author: klausw <klausw@chromium.org> Date: Tue May 30 19:59:04 2017 Use standard-priority GL context for VrShellGl. The high-priority GL context appears to be conflicting with GVR's internal high priority context for async reprojection, so we can't use that in other VR code. BUG= 727800 , 725684 Review-Url: https://codereview.chromium.org/2909163003 Cr-Commit-Position: refs/heads/master@{#475634} [modify] https://crrev.com/01693c7c9e98c2a4f3809cb1b4d6ae7b97eab02f/chrome/browser/android/vr_shell/vr_shell_gl.cc
,
May 30 2017
,
May 30 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05bac91e966e8be06039390c1cb44a51f0e5957f commit 05bac91e966e8be06039390c1cb44a51f0e5957f Author: klausw <klausw@chromium.org> Date: Tue May 30 21:18:04 2017 Use standard-priority GL context for VrShellGl. The high-priority GL context appears to be conflicting with GVR's internal high priority context for async reprojection, so we can't use that in other VR code. BUG= 727800 , 725684 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2909163003 Cr-Original-Commit-Position: refs/heads/master@{#475634} Review-Url: https://codereview.chromium.org/2909393002 Cr-Commit-Position: refs/branch-heads/3112@{#40} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/05bac91e966e8be06039390c1cb44a51f0e5957f/chrome/browser/android/vr_shell/vr_shell_gl.cc
,
Jul 26 2017
Hi Klaus, I verified this by testing 60.0.3112.78 using our webvr samples pages on a Pixel with the Daydream headset, and ensured I did not notice any screen tearing. And also by testing wikipedia.org in VR browser. Please let me know if there are other ways I would need to verify. Thanks!
,
Jul 26 2017
@dbbrooks, thank you for verifying. That should be sufficient, I'm pretty confident that the context priority conflict was the cause of tearing and that the change from comment #5 fixed it, and I also haven't seen it myself in further testing.
,
Jul 4
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by klausw@chromium.org
, May 30 2017