New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 727792 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 716280
issue 727774



Sign in to add a comment

Clean up all post methods in the repo

Project Member Reported by st...@chromium.org, May 30 2017

Issue description

There are some unneeded post methods in http handlers, while some get methods should be post ones instead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2ab5afbc513452aeba0361c95cdd5446e37e2d04

commit 2ab5afbc513452aeba0361c95cdd5446e37e2d04
Author: Shuotao Gao <stgao@chromium.org>
Date: Wed Jun 07 05:23:42 2017

[Findit] Add XSRF token to triage-related endpoints.

Bug:  727797 ,  727792 , 716280
Change-Id: Ie7c9fe92e7a1e20fc5af6541cae1a0efedc4b72c
Reviewed-on: https://chromium-review.googlesource.com/526852
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/handlers/list_analyses.py
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/templates/build_failure.html
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/handlers/help_triage.py
[add] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/ui/elements/analysis/triage-help-demo.html
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/handlers/test/check_duplicate_failures_test.py
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/handlers/test/help_triage_test.py
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/templates/flake/result.html
[add] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/ui/elements/analysis/triage-help.html
[modify] https://crrev.com/2ab5afbc513452aeba0361c95cdd5446e37e2d04/appengine/findit/handlers/check_duplicate_failures.py

Comment 3 by st...@chromium.org, Jun 7 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/10f8637e68e7474ccdc41e3d117697b515a21b28

commit 10f8637e68e7474ccdc41e3d117697b515a21b28
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jun 08 17:54:46 2017

Sign in to add a comment