When assigning a slave to a tryjob, interpret tryjob.dimensions as a list of colon separated pairs of strings, instead of a dict. |
|||
Issue descriptionTypeError: list indices must be integers, not str at AssignWarmCacheHost (/base/data/home/apps/s~findit-for-me/waterfall-backend:29a9b988a7.401442530312179027/waterfall/swarming_util.py:706) at _TriggerTryJob (/base/data/home/apps/s~findit-for-me/waterfall-backend:29a9b988a7.401442530312179027/waterfall/schedule_try_job_pipeline.py:64)
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1e5d8794321fbf27bb12875ecfe5c6154fba2ef8 commit 1e5d8794321fbf27bb12875ecfe5c6154fba2ef8 Author: Roberto Carrillo <robertocn@google.com> Date: Tue May 30 19:00:29 2017 [Findit] Treat dimensions as a list of colon-separated string pairs. In AssignWarmCacheHost we were mistakenly treating a tryjob's dimensions as a dictionary, and this is causing exceptions when triggering jobs on bots that have already run jobs. R=stgao,chanli,lijeffrey BUG= 727789 Change-Id: I3944167aa799a1410e9b585c1a0c265ad72a6c3a Reviewed-on: https://chromium-review.googlesource.com/517971 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/1e5d8794321fbf27bb12875ecfe5c6154fba2ef8/appengine/findit/waterfall/swarming_util.py [modify] https://crrev.com/1e5d8794321fbf27bb12875ecfe5c6154fba2ef8/appengine/findit/waterfall/test/swarming_util_test.py
,
May 30 2017
,
May 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by robert...@chromium.org
, May 30 2017