New issue
Advanced search Search tips

Issue 727786 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 719108



Sign in to add a comment

NetInfo API: Returned network quality should be a multiple of 25 msec or 25 kbps

Project Member Reported by tbansal@chromium.org, May 30 2017

Issue description

The NetInfo API spec requires that the returned network quality should be a multiple of 25 msec or 25 kbps. See https://cdn.rawgit.com/WICG/netinfo/ect/index.html#-downlink-attribute.

The current implementation ensures that |downlink| is a multiple of 25 kbps except in one case of when the |downlink| is unavailable. We should fix that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420ae3445c9b1530ba81ac651966d01548c04d09

commit 420ae3445c9b1530ba81ac651966d01548c04d09
Author: tbansal <tbansal@chromium.org>
Date: Tue Jun 06 07:31:40 2017

NetInfo: Slight update to the default network quality value

This CL changes the default values of |downlink| to be a multiple of
25 kbps.

BUG= 727786 

Review-Url: https://codereview.chromium.org/2912013002
Cr-Commit-Position: refs/heads/master@{#477227}

[modify] https://crrev.com/420ae3445c9b1530ba81ac651966d01548c04d09/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/420ae3445c9b1530ba81ac651966d01548c04d09/content/test/data/net_info.html
[modify] https://crrev.com/420ae3445c9b1530ba81ac651966d01548c04d09/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 723068
Blocking: -723068 719108
Please merge the patch to M60 branch(3112),Beta RC cut is scheduled @ 4.00 PM PST today(06/07).

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22922b662424d54269fdcb2625622b9f842bb627

commit 22922b662424d54269fdcb2625622b9f842bb627
Author: Tarun Bansal <tbansal@google.com>
Date: Thu Jun 08 22:09:46 2017

NetInfo: Slight update to the default network quality value

This CL changes the default values of |downlink| to be a multiple of
25 kbps.

BUG= 727786 

Review-Url: https://codereview.chromium.org/2912013002
Cr-Original-Commit-Position: refs/heads/master@{#477227}
Review-Url: https://codereview.chromium.org/2929703003 .
Cr-Commit-Position: refs/branch-heads/3112@{#270}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/22922b662424d54269fdcb2625622b9f842bb627/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/22922b662424d54269fdcb2625622b9f842bb627/content/test/data/net_info.html
[modify] https://crrev.com/22922b662424d54269fdcb2625622b9f842bb627/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

Status: Fixed (was: Started)

Sign in to add a comment