New issue
Advanced search Search tips

Issue 727783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Enable media_blink_unittests on Android bots

Project Member Reported by xhw...@chromium.org, May 30 2017

Issue description

Today media_blink_unittests are not running on Android bots [1], and a local run shows that some tests are failing. We should fix the failing tests and enable media_blink_unittests on some Android bots to get proper test coverage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8947f9db1b1bd58ea60a6638e8e889f07c5a362

commit c8947f9db1b1bd58ea60a6638e8e889f07c5a362
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Jun 01 04:27:45 2017

media: Fix KeySystemConfigSelectorTest on Android

Also enable media_blink_tests on Android bots to prevent this from
happening again.

Note that platform Opus is only supported on Android L and above.
Therefore some tests may fail on older devices (e.g. KitKat). This
difference isn't really interesting to KeySystemConfigSelectorTest
though.

In a future CL, I will fix the test further to make it work on older
devices.

BUG= 727783 
TEST=Fixes existing tests and enable tests on more bots.

Change-Id: I93becd70216575122e149bd89fb77e4d506d332f
Reviewed-on: https://chromium-review.googlesource.com/518626
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476190}
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/media/base/key_systems.cc
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/media/base/mime_util_internal.cc
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/media/blink/key_system_config_selector.cc
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/media/blink/key_system_config_selector_unittest.cc
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/media/blink/run_all_unittests.cc
[modify] https://crrev.com/c8947f9db1b1bd58ea60a6638e8e889f07c5a362/testing/buildbot/chromium.android.json

Status: Fixed (was: Assigned)

Sign in to add a comment