New issue
Advanced search Search tips

Issue 727766 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Milo generating 500 responses

Project Member Reported by davidri...@chromium.org, May 30 2017

Issue description

I'm getting repeated 500 errors from a lot of Milo requests:
10:24:41: ERROR: Unable to GetBuildbotBuildJSON chromeos kevin-paladin:1178: Got a 500 response with url: https://luci-milo.appspot.com/prpc/milo.Buildbot/GetBuildbotBuildJSON
content: Internal Server Error

10:24:41: INFO: Running cidb query on pid 52662, repr(query) starts with 'SELECT c.id, b.id, action, c.reason, build_config, change_number, patch_number, change_source, time
10:24:42: ERROR: Unable to get suites for chromeos kevin-paladin:1178: Got a 500 response with url: https://luci-milo.appspot.com/prpc/milo.BuildInfo/Get
content: Internal Server Error

If I do the query via the RPC explorer it seems to work:
https://luci-milo.appspot.com/rpcexplorer/services/milo.BuildInfo/Get?request={%20%20%20%20%22buildbot%22:%20{%20%20%20%20%20%20%20%20%22masterName%22:%20%22chromeos%22,%20%20%20%20%20%20%20%20%22builderName%22:%20%22kevin-paladin%22,%20%20%20%20%20%20%20%20%22buildNumber%22:%201178%20%20%20%20}}

And I've been using the same code and having it work for many other requests.
 

Comment 1 by hinoka@chromium.org, May 30 2017

Talked offline, it is an invalid oauth_token, most likely because it expired.

Comment 2 by no...@chromium.org, May 30 2017

Ideally we should never return http 500. Unhappy-path user input should result in 4xx

Comment 3 by hinoka@chromium.org, May 30 2017

crbug.com/727820 for unhappy user input -> 4xx

Comment 4 by no...@chromium.org, May 30 2017

bug 727820 title seems to indicate it is about oauth, but i am talking about any user input

Comment 5 by hinoka@chromium.org, Jun 12 2017

Status: WontFix (was: Untriaged)
This was an error with invalid oauth tokens, marking as wontfix.  Bug for 4xx reponses for oauth errors in 727820

Sign in to add a comment