New issue
Advanced search Search tips

Issue 727757 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Previous locations:
gerrit:5345


Sign in to add a comment

Show Code-Review+1 button on merged CLs that landed with TBR

Project Member Reported by serg...@chromium.org, Jan 26 2017

Issue description

This would make it easier to LGTM CLs that landed with TBR.
 
Labels: Milestone-Chromium-Afterglow Type-Feature Priority-2
Owner: vikt...@google.com
Status: Accepted (was: New)
I suspect this issue is possibly the same as  issue 5625 

Comment 3 by vikt...@google.com, May 26 2017

Cc: logan@google.com aga...@chromium.org
Gerrit proper has no support for TBR, so this calls for plugin, I guess.

Comment 4 by aga...@chromium.org, May 30 2017

Project: chromium
Moved issue gerrit:5345 to now be issue chromium:727757.

Comment 5 by aga...@chromium.org, May 30 2017

Cc: vikt...@google.com
Components: Infra>Codereview>Gerrit
Labels: -Priority-2 -Milestone-Chromium-Afterglow Milestone-Afterglow Proj-Gerrit-Migration Pri-2
Owner: ----
Status: Available (was: Accepted)
We'll build this into our existing button-manipulation plugin.

Comment 6 by vikt...@google.com, May 30 2017

👍 Looking forward for API requirements.

Comment 7 by aga...@chromium.org, May 30 2017

Don't think we'll need any; we can already detect
a) if the change has been merged
b) who approved it (and whether it was you)
c) whether the quick action button is being displayed
d) etc etc I totally think we have enough information to do this
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
Cc: -logan@google.com -vikt...@google.com -aga...@chromium.org
Removing everyone cc'd on the bug as I know they've moved teams and probably no longer care about this.

Sign in to add a comment