Having button to land patches that bypasses CQ is dangerous and easy to miss |
||
Issue descriptionWith Rietveld there was no UI to bypass the CQ. The Gerrit ui has a button that lands directly (more -> Submit), yet it isn't clear this bypasses the CQ. We should either remove this button, or make it super super clear that it bypasses the CQ. Most likely by changing the name *and* having it bring up a dialog warning the user.
,
May 31 2017
If you use the Submit button in chromium/src (or v8, or any of the infra repos, etc) today, you will get a big warning popup. This is managed by the chumpdetector plugin[1], and by chromium's configuration of it[2]. We are wary of changing the name, because "Submit" is a word that is used throughout Gerrit internals (including the JSON api), and we think it is good for users to know/learn exactly what that word means inside this system. [1] https://chromium.googlesource.com/infra/gerrit-plugins/chumpdetector/ [2] https://chromium.googlesource.com/chromium/src/+/refs/meta/config/chumpdetector.config
,
May 31 2017
I clicked the 'submit' button yesterday and got no warning. Was the warning added yesterday?
,
May 31 2017
I had misconfigured it; thanks to this report I fixed it! |
||
►
Sign in to add a comment |
||
Comment 1 by sky@chromium.org
, May 30 2017