New issue
Advanced search Search tips

Issue 727739 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Select-to-Speak settings tweak

Project Member Reported by lpalmaro@chromium.org, May 30 2017

Issue description

OS: Chrome

A small inconsistency Kathy pointed out: 

When you open the Select-to-Speak settings, US English is selected by default. 
All good.
Speech rate is blank and ChromeVox rightly says that the pop-up is collapsed.

Should the speech rate be populated automatically with "Normal," like the language is populated? And should ChromeVox indicate Normal is selected? I get that Normal is a default setting, but on the UI, the setting is blank, whereas the language is populated.

 
Owner: ----

Comment 2 by katydek@google.com, Sep 20 2017

Owner: katydek@google.com
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca651ab4354c07b5735e786e2d663b3b7a0d6d70

commit ca651ab4354c07b5735e786e2d663b3b7a0d6d70
Author: Katie Dektar <katydek@google.com>
Date: Thu Sep 21 02:29:24 2017

Fix speech rate item population.

When a user has not ever selected a speech rate, the item was
not populate correctly.

Also fixes a scope issue in a callback function that seems to
have no impact.

Bug:  727739 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice87344c145e6ff189efedf4bc694c9229736049
Reviewed-on: https://chromium-review.googlesource.com/675840
Commit-Queue: Katie Dektar <katydek@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503317}
[modify] https://crrev.com/ca651ab4354c07b5735e786e2d663b3b7a0d6d70/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/ca651ab4354c07b5735e786e2d663b3b7a0d6d70/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js

Comment 4 by katydek@google.com, Sep 21 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment